Skip to content

Downgrade click version #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,9 @@ jobs:
# sudo chmod u+x ./selenium-server-standalone.jar
# xvfb-run --auto-servernum python atest/run.py --zip headlesschrome --grid True

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: failure()
with:
name: SeleniumLibrary Test results
path: atest/zip_results
overwrite: true
2 changes: 1 addition & 1 deletion atest/acceptance/locators/custom.robot
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,4 @@ Teardown Custom Locator
Custom Locator Strategy
[Arguments] ${browser} ${locator} ${tag} ${constraints}
${element}= Execute Javascript return window.document.getElementById('${locator}') || [];
[Return] ${element}
RETURN ${element}
2 changes: 1 addition & 1 deletion atest/acceptance/resource.robot
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Open Browser To Start Page Without Testing Default Options
... desired_capabilities=${DESIRED_CAPABILITIES} alias=${alias}
${orig speed} = Set Selenium Speed ${SPEED}
${orig timeout} = Set Selenium Timeout 10 seconds
[Return] ${orig speed} 5 seconds
RETURN ${orig speed} 5 seconds

Cannot Be Executed In IE
[Documentation] Cannot Be Executed In IE
Expand Down
2 changes: 1 addition & 1 deletion atest/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ def process_output(browser):
print("Verifying results...")
options = []
output = os.path.join(RESULTS_DIR, "output.xml")
robotstatuschecker.process_output(output, verbose=False)
robotstatuschecker.process_output(output)
options.extend([opt.format(browser=browser) for opt in REBOT_OPTIONS])
try:
rebot_cli(options + [output])
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
selenium >= 4.3.0
robotframework >= 4.1.3
robotframework-pythonlibcore >= 4.4.1
click >= 8.1.7
click >= 8.0
2 changes: 1 addition & 1 deletion src/SeleniumLibrary/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ class SeleniumLibrary(DynamicCore):

| Custom Locator Strategy | [Arguments] | ${browser} | ${locator} | ${tag} | ${constraints} |
| | ${element}= | Execute Javascript | return window.document.getElementById('${locator}'); |
| | [Return] | ${element} |
| | RETURN | ${element} |

This keyword is a reimplementation of the basic functionality of the
``id`` locator where ``${browser}`` is a reference to a WebDriver
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ a WebElement that should be acted on:

| Custom Locator Strategy | [Arguments] | ${browser} | ${locator} | ${tag} | ${constraints} |
| | ${element}= | Execute Javascript | return window.document.getElementById('${locator}'); |
| | [Return] | ${element} |
| | RETURN | ${element} |

This keyword is a reimplementation of the basic functionality of the
``id`` locator where ``${browser}`` is a reference to a WebDriver
Expand Down
Loading