Increase default capacities #7753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on a discussion with Richard (quite a while ago at this point), lets default to over-allocating our array sizes. This is in hopes that the normal flow never reallocates. We really don't use that much memory in total and this enables the compiler to see solid speed gains. Until we find a reason not to or get better heuristics, lets use memory to save time.
Anton-4
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a discussion with Richard (quite a while ago at this point), lets default to over-allocating our array sizes. This is in hopes that the normal flow never reallocates. We really don't use that much memory in total and this enables the compiler to see solid speed gains. Until we find a reason not to or get better heuristics, lets use memory to save time.
Also removes and extraneous debug print and updates one case of
initWithCapacitytoinitCapacity