Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmx_3600 adapter: support multiple markers per clip #593 #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

elabrosseRodeofx
Copy link

@elabrosseRodeofx elabrosseRodeofx commented Sep 27, 2019

Right now the cmx_3600 adapter does not support multiple markers per clip.
This is due to the fact that CommentHandler assumes a single locator comment per line.

This is the content of an EDL file exported from Avid media composer:

TITLE:   Untitled Sequence.01
FCM: NON-DROP FRAME
001  103043_0 V     C        01:00:00:00 01:00:08:10 01:00:00:00 01:00:08:10
* FROM CLIP NAME:  MYMEDIA.MOV
* LOC: 01:00:02:01 RED     FIRST MARKER NAME
* LOC: 01:00:04:10 RED     SECOND MARKER NAME
* LOC: 01:00:05:19 RED     THIRD MARKER NAME

Current behavior:

>>> timeline = otio.adapters.read_from_file('/devLocal/elabrosse/rdoenv/auto_lineup/markers.edl')
>>> list(timeline.each_clip())[0].markers
[
otio.schema.Marker(name='THIRD MARKER NAME', marked_range=otio.opentime.TimeRange(start_time=otio.opentime.RationalTime(value=86539, rate=24), duration=otio.opentime.RationalTime(value=0, rate=1)), metadata={'cmx_3600': {'color': u'RED'}})
]

As you can see only the last marker is present in the list.

with the fix:

>>> import opentimelineio as otio
>>> timeline = otio.adapters.read_from_file('/path/to/myEdl.edl')
>>> list(timeline.each_clip())[0].markers

[
    otio.schema.Marker(name='FIRST MARKER NAME', marked_range=otio.opentime.TimeRange(start_time=otio.opentime.RationalTime(value=86449, rate=24.0), duration=otio.opentime.RationalTime(value=0.0, rate=1.0)), metadata={'cmx_3600': {'color': 'RED'}}),
    otio.schema.Marker(name='SECOND MARKER NAME', marked_range=otio.opentime.TimeRange(start_time=otio.opentime.RationalTime(value=86506, rate=24.0), duration=otio.opentime.RationalTime(value=0.0, rate=1.0)), metadata={'cmx_3600': {'color': 'RED'}}),
    otio.schema.Marker(name='THIRD MARKER NAME', marked_range=otio.opentime.TimeRange(start_time=otio.opentime.RationalTime(value=86539, rate=24.0), duration=otio.opentime.RationalTime(value=0.0, rate=1.0)), metadata={'cmx_3600': {'color': 'RED'}})
]

@elabrosseRodeofx elabrosseRodeofx changed the title Support multiple markers per clip for cmx_3600 adapter (issue-593) Support multiple markers per clip for cmx_3600 adapter #593 Sep 27, 2019
@elabrosseRodeofx elabrosseRodeofx changed the title Support multiple markers per clip for cmx_3600 adapter #593 cmx_3600 adapter: Support multiple markers per clip #593 Sep 27, 2019
@elabrosseRodeofx elabrosseRodeofx changed the title cmx_3600 adapter: Support multiple markers per clip #593 cmx_3600 adapter: support multiple markers per clip #593 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant