{On hold} v1.4.2_rdo7 to v1.9.1_rdo #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e publish name We allow multiple tasks to produce the same output so we just want to display one stream of publishes for a given name. Our publish system being name based two different publishes can't share the same name. They may be from different departments (cmm or layout cameras) but then they are just two different versions of the same output.
I tweaked the _on_before_paint method to allow easy customization of the delegate through inheritance. Subclasses just have to override the get_name_string and get_details_string methods to change what's painted in the item.
JeanChristopheMorinRodeoFX
changed the title
Filter Loader by Status
dialog: dynamically create status filter list
|
I need to rename everything named with |
| @@ -143,3 +143,4 @@ requires_engine_version: | |||
| frameworks: | |||
| - {"name": "tk-framework-shotgunutils", "version": "v4.x.x"} | |||
| - {"name": "tk-framework-qtwidgets", "version": "v2.x.x"} | |||
| - {"name": "tk-framework-rdo", 'version': "v0.0.x"} | |||
There was a problem hiding this comment.
Do we want to share our framework? It is used only for the icons right?
There was a problem hiding this comment.
From Julien (in git colony):
It's used for the icons and for the custom widget we use for the load options. We won't share it
|
If we want to share that with Shotgun, we might want to make the status filter update faster. When we open the loader, it takes a lot of time to get the number of items for each status, which is quite annoying. |
| @@ -0,0 +1,80 @@ | |||
| # Copyright (c) 2013 Shotgun Software Inc. | |||
JeanChristopheMorinRodeoFX
changed the title
…on in list view (RPS-243)
…pp settings (RPS-243)
JeanChristopheMorinRodeoFX
force-pushed
the
dev_update_app_2
branch
from
7a85ae0 to
fc3ef08
Compare
JeanChristopheMorinRodeoFX
changed the title
JeanChristopheMorinRodeoFX
changed the title
|
Initial PR was #10 but shotgunsoftware#111 has a better version, nicely integrated with new changes, with sme changes made by me. Nothing major, just changes the search widget to avoid code duplication and a little UI bug in XSI. |
JeanChristopheMorinRodeoFX
changed the title
| @@ -276,6 +272,18 @@ def __init__(self, action_manager, parent=None): | |||
| show_details = self._settings_manager.retrieve("show_details", False) | |||
| self._set_details_pane_visiblity(show_details) | |||
|
|
|||
| # Add rdo custom UI | |||
| hlayout = QtGui.QHBoxLayout() | |||
| spacerItem = QtGui.QSpacerItem(40, 20, QtGui.QSizePolicy.Expanding, QtGui.QSizePolicy.Minimum) | |||
JeanChristopheMorinRodeoFX
changed the title
JeanChristopheMorinRodeoFX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with Julien, I merged our changes into shotgun changes to be able to send them our version.
First 8 commits have been cherry-picked from
master_rdo. My commits are for the publishes search which needed a little cleanup and merged some stuff to avoid code duplication.I still need to add one or two line to make the zoom slider (when in thumb view) disappear when we switch in list view.
This change is