-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added user db schema #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think before we can push to main, we need to confirm what we are storing in our DB(s), what DB we are using and the shape/schema. Once we have that sorted I think we also need to make sure we have test files included before pushing to main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for
- the indentation in some
.yaml
-files but that is apparently not a problem? - the fact that there are 2 topics in this 1 PR (but that's ok for now, let's try to avoid it in the future)
- the fact that there are no tests yet (which IMO is also ok for now, as we're still in very early stages)
log.Fatalf("fatal error config file: %v", err.Error()) | ||
} | ||
|
||
// database connection shouldn't be implemented here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead and delete this commented-out code if you're going to use config.go
to setup the DB connection
Description
Dependent #1
Current status
Semantic Versioning
feat
changeType of change
Please delete options that are not relevant.