-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to use a different wrapper than Option
#9
Open
roignpar
wants to merge
17
commits into
main
Choose a base branch
from
wrapper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an optfield invocation without custom wrapper
wrap fields in custom wrapper instead of Option
fix existing and add a few more tests
Implementation is done.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
wrapper
argument to optfield that allows using a different wrapper thanOption
around the generated fields.The custom wrapper type must have a signature taking exactly one generic type:
MyWrapper<T>
. The custom wrapper can be a struct, tuple, or enum as long as the signature is respected.merge_fn
will have a slightly different behavior whenwrapper
is used: aFrom<MyWrapper<T>> for Option<T>
implementation must exist, either generically or specifically for all the field types used in the target struct.In case the target struct already has
MyWrapper
fields andrewrap
is not used aFrom<&MyWrapper<T>> for Option<()>
is also required in order to be able to determine whether the valued should be merged or not. This will be explained in detail in the documentation.If
merge_fn
is not used then these implementations are not necessary.Similarly, when
from
is used, aFrom<T> for MyWrapper<T>
implementation must exist, either generically or specifically for all the field types of the target struct.If
from
is not used then these implementations are not necessary.When used together with
wrapper
rewrap
will target the given wrapper type instead of Option.A simple example:
More examples in
tests/wrapper.rs
and docs.Closes #8