Add flag to listen on 0.0.0.0 #12
Conversation
WalkthroughThe update introduces a new Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
README.md (1)
22-22: Consider adding a comma after "flag" for improved readability: "You can also run mock-da with a-listen-allflag, which will make the process listen on 0.0.0.0 so that it can be accessed from other machines."
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- README.md (1 hunks)
- cmd/mock-da/main.go (1 hunks)
Additional Context Used
LanguageTool (2)
README.md (2)
Near line 22: Possible missing comma found.
Context: ...n also run mock-da with a-listen-allflag which will make the process listen on 0...
Near line 83: Unpaired symbol: ‘]’ seems to be missing
Context: ... "id": "1" } ``` ## References [1] [go-da][go-da] [2] [xh][xh] [go-da]: ht...
Additional comments not posted (3)
cmd/mock-da/main.go (3)
18-19: The change fromMockDAAddresstoMockDAPortis clear and aligns well with the PR's objectives to enhance network configuration flexibility.
22-22: The introduction of thelistenAllflag with a default value offalseis a thoughtful approach to maintain backward compatibility while offering new functionality.
29-33: The logic to determine the server's listening IP based on thelistenAllflag is implemented correctly and effectively.
|
Thanks @gjermundgaraba for the contribution! Updated to use |
I wanted to run mock-da with interchaintest as a sidecar, but quickly (not quickly enough) found out that the process only listens on localhost. So I had to make a little adjustment to support listening on 0.0.0.0 so that it would be accessible between containers.
If you want this change, here it is :) I updated the readme as well to document the change.
Summary by CodeRabbit
-listen-allflag formock-dato enable listening on all network interfaces, allowing access from other machines.