-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kurtosis package #25
Conversation
WalkthroughThe recent changes across several configuration files focus on refining CI/CD processes and supporting new features for local Data Aggregator services. Changes include broadening version tag triggers for workflows, adding a Dockerfile lint job, and configuring Kurtosis for Rollkit Local DA. Additionally, a new function is introduced in Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub Actions
participant Docker
participant Kurtosis
participant DA_Service
User->>GitHub Actions: Push code with 'v' tag
GitHub Actions->>GitHub Actions: Trigger CI workflows
GitHub Actions->>Docker: Run Dockerfile linting
GitHub Actions->>Kurtosis: Apply configuration settings
User->>DA_Service: Initiate `run(plan)` function
DA_Service->>DA_Service: Setup local DA, configure ports
DA_Service-->>User: Return rollup addresses
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .github/workflows/ci_release.yml (1 hunks)
- .github/workflows/docker-build-publish.yml (1 hunks)
- .github/workflows/lint.yml (1 hunks)
- kurtosis.yml (1 hunks)
- main.star (1 hunks)
Files skipped from review due to trivial changes (4)
- .github/workflows/ci_release.yml
- .github/workflows/docker-build-publish.yml
- .github/workflows/lint.yml
- kurtosis.yml
Additional comments not posted (4)
main.star (4)
3-12
: Good use of PortSpec for defining ports.The port specification and mapping look correct. This ensures that the service will listen on the defined port using the specified protocols.
13-20
: Service configuration is well-structured.The service configuration uses the correct image and maps the defined ports. Public ports are also correctly specified.
22-25
: Ensure the service is reachable.The address formation for the local DA service is correct. Ensure that the service is reachable at the formed address.
27-27
: LGTM!The function correctly returns the address of the local DA service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
Overview
Extract kurtosis package from GM tutorial.
Closes rollkit/rollkit#1766
Summary by CodeRabbit
New Features
Chores