fix(replace): objectGuards doesn't take effects

BREAKING CHANGES: Fixed the problem that the objectGuards option did not take effect, so the bundle results before and after may be inconsistent
rollup · Sep 23, 2024 · 6b4ee00 · 6b4ee00
1 parent 28b9701
commit 6b4ee00
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 20 deletions.
diff --git a/packages/replace/src/index.js b/packages/replace/src/index.js
@@ -43,26 +43,10 @@ function expandTypeofReplacements(replacements) {
     const objMatch = key.match(objKeyRegEx);
     if (!objMatch) return;
     let dotIndex = objMatch[1].length;
-    let lastIndex = 0;
     do {
       // eslint-disable-next-line no-param-reassign
-      replacements[`typeof ${key.slice(lastIndex, dotIndex)} ===`] = '"object" ===';
-      // eslint-disable-next-line no-param-reassign
-      replacements[`typeof ${key.slice(lastIndex, dotIndex)} !==`] = '"object" !==';
-      // eslint-disable-next-line no-param-reassign
-      replacements[`typeof ${key.slice(lastIndex, dotIndex)}===`] = '"object"===';
-      // eslint-disable-next-line no-param-reassign
-      replacements[`typeof ${key.slice(lastIndex, dotIndex)}!==`] = '"object"!==';
-      // eslint-disable-next-line no-param-reassign
-      replacements[`typeof ${key.slice(lastIndex, dotIndex)} ==`] = '"object" ===';
-      // eslint-disable-next-line no-param-reassign
-      replacements[`typeof ${key.slice(lastIndex, dotIndex)} !=`] = '"object" !==';
-      // eslint-disable-next-line no-param-reassign
-      replacements[`typeof ${key.slice(lastIndex, dotIndex)}==`] = '"object"===';
-      // eslint-disable-next-line no-param-reassign
-      replacements[`typeof ${key.slice(lastIndex, dotIndex)}!=`] = '"object"!==';
-      lastIndex = dotIndex + 1;
-      dotIndex = key.indexOf('.', lastIndex);
+      replacements[`typeof ${key.slice(0, dotIndex)}`] = '"object"';
+      dotIndex = key.indexOf('.', dotIndex + 1);
     } while (dotIndex !== -1);
   });
 }

diff --git a/packages/replace/test/fixtures/form/process-check/input.js b/packages/replace/test/fixtures/form/process-check/input.js
@@ -1,3 +1,3 @@
-if (typeof process !== 'undefined' && process.env.NODE_ENV === 'production') {
+if (typeof process !== 'undefined' && typeof process.env === "object" && process.env.NODE_ENV === 'production') {
   console.log('production');
 }
diff --git a/packages/replace/test/snapshots/form.js.md b/packages/replace/test/snapshots/form.js.md
@@ -43,7 +43,7 @@ Generated by [AVA](https://avajs.dev).
 
 > Snapshot 1
 
-    `if (typeof process !== 'undefined' && "production" === 'production') {␊
+    `if ("object" !== 'undefined' && "object" === "object" && "production" === 'production') {␊
       console.log('production');␊
     }`
 

diff --git a/packages/replace/test/snapshots/form.js.snap b/packages/replace/test/snapshots/form.js.snap