fix: epoll socket async chaining and refactor #374
Conversation
Signed-off-by: kostas <[email protected]>
|
@romange Fixes the test case as well in DF. I could add a test here but that's something I will be doing anyway when I push my |
util/fibers/epoll_socket.cc
Outdated
| delete async_request; | ||
| async_request = nullptr; | ||
| if (is_send) | ||
| async_write_pending_ = 0; |
There was a problem hiding this comment.
Cause lambdas can't capture and use bitfields 😮💨
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 77.60% 77.83% +0.23%
==========================================
Files 103 109 +6
Lines 7824 9016 +1192
==========================================
+ Hits 6072 7018 +946
- Misses 1752 1998 +246 ☔ View full report in Codecov by Sentry. |
util/fibers/epoll_socket.cc
Outdated
| delete async_read_req_; | ||
| async_read_req_ = nullptr; | ||
| async_read_pending_ = 0; | ||
| auto body = [&ec, this](bool is_send) { |
There was a problem hiding this comment.
since it captures this, please make it a member function that returns error_code.
There was a problem hiding this comment.
So much better now, I really don't know what I was thinking with this large lambda
Signed-off-by: kostas <[email protected]>
|
@romange there seem to be a problem with docker on the CI. I also can't rerun the workflow 😢 |
Fixes the problem described in dragonflydb/dragonfly#4498 and here dragonflydb/dragonfly#4498 (comment)