Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROMM-994] Autogenerated collections #1562

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

[ROMM-994] Autogenerated collections #1562

wants to merge 16 commits into from

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Jan 29, 2025

Description

Very excited about this time! This PR creates a virtual database table that collects and groups games based on certain IGDB metadata fields: collections, franchises, genres, companies and modes. The list of virtual VirtualCollections can be fetched and filtered by type, and displayed in the home screen and collections sidebar. Editing these virtual collections is not possible, so controls like the collection editor window are hidden.

As we add more metadata providers, we can update the virtual table to pull properties outside igdb_metadata.

TODO

  • Test migration with postgresql

Related Issues

Closes #994

Checklist

Please check all that apply.

  • I've tested the changes locally
  • I've updated the wiki accordingly
  • I've have updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes
  • All existing tests are passing

Screenshots

Screenshot 2025-01-28 at 7 00 51 PMScreenshot 2025-01-28 at 7 04 04 PM Screenshot 2025-01-28 at 9 52 22 PM

Copy link

github-actions bot commented Jan 29, 2025

Test Results

93 tests   93 ✅  27s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 81fd535.

♻️ This comment has been updated with latest results.

@zurdi15 zurdi15 closed this Jan 30, 2025
@zurdi15 zurdi15 deleted the romm-994 branch January 30, 2025 22:47
@zurdi15 zurdi15 restored the romm-994 branch January 30, 2025 22:49
@zurdi15 zurdi15 reopened this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants