[ntuple] Simplify and clean up compression #17847
Open
+40
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 18 files 18 suites 4d 8h 13m 37s ⏱️ For more details on these failures, see this check. Results for commit 5423345. ♻️ This comment has been updated with latest results. |
enirolf
approved these changes
Feb 28, 2025
InitImpl, CommitClusterGroupImpl, and CommitDatasetImpl already allocate a buffer that is large enough and it is not needed to pass via the internal buffer of RNTupleCompressor just to memcpy the compressed contents out again.
It was already unused in SealPage since commit 208061d ("fix unbuffered compression of large pages"). This saves 16 MiB of internal compression buffer per page sink.
A RNTupleDecompressor will internally allocate a buffer of 16 MiB, which is not needed for the anchor. It was also the only usage of in-place decompression with RNTupleDecompressor.
They are not used anymore in the source code.
They are not used anymore in the source code.
hahnjo
force-pushed
the
ntuple-compressor
branch
from
5423345 to
d1b534d
Compare
|
(just rebasing to get a green CI before merging) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... eventually removing all member methods of RNTuple(De)Compressor; see the individual commits for more details. As a visible result, this saves 16 MiB of internal compression buffer per page sink.