-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[math] implement genvector custom axis rotation #18462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 19 files 19 suites 4d 10h 23m 26s ⏱️ Results for commit 96fb2e8. ♻️ This comment has been updated with latest results. |
Thanks for this PR. As I wrote in the forum post, the new Edit: Of course the other solution implemented in #18480 will also solve the issue by enabling the usage of |
as suggested by mdessole
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ferdymercury,
thanks for taking this up! Also here, having a small test would make it easier to judge what's going on.
One more function in https://github.com/root-project/root/blob/master/math/genvector/test/stress3D.cxx maybe.
Better here: https://github.com/root-project/root/blob/master/math/genvector/test/testGenVector.cxx
as suggested by hageboeck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ferdymercury! LGTM!
Let's wait for the builds to complete.
Co-authored-by: Bertrand Bellenot <[email protected]>
This Pull request:
Changes or fixes:
Fixes https://root-forum.cern.ch/t/tvector3-rotate-to-arbitrary-rotation-using-xyzvector/63244
Checklist: