Skip to content

Add possibility to disable drawer from context #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

magrinj
Copy link

@magrinj magrinj commented Nov 22, 2016

No description provided.

@rt2zz
Copy link
Member

rt2zz commented Nov 23, 2016

I like this change conceptually, but
a) want to wait until the (hopefully) forthcoming Animated overhaul lands as that may necessitate some larger overall changes
b) am worried that this make use of the disabled prop ambiguous

@magrinj
Copy link
Author

magrinj commented Nov 30, 2016

I understand your first point, for the second one I don't really think it's a problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants