Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename type & id columns to osm_type & osm_id for osmapi_objects in tags_wide format #12

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

jmaspons
Copy link
Collaborator

Avoid clashes with tag keys in columns. FIX #9

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 55.00000% with 90 lines in your changes are missing coverage. Please review.

Project coverage is 81.27%. Comparing base (8e2f5dd) to head (7a014f0).

Files Patch % Lines
R/osmapiR_objects.R 16.66% 65 Missing ⚠️
R/R_to_xml.R 77.14% 24 Missing ⚠️
R/osmchange.R 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   85.09%   81.27%   -3.83%     
==========================================
  Files          21       22       +1     
  Lines        1590     1762     +172     
==========================================
+ Hits         1353     1432      +79     
- Misses        237      330      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmaspons jmaspons merged commit 3aad1e7 into main Feb 23, 2024
7 of 9 checks passed
@jmaspons jmaspons deleted the osm_id branch February 23, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename type, id & version columns for osmapi_objects by prepending osm_
1 participant