Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set core.autocrlf on windows GHA #28

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

nealrichardson
Copy link
Contributor

I stumbled across https://github.com/nealrichardson/httptest2/blob/main/.github/workflows/R-CMD-check.yaml#L30-L32 just now and realized that could be the source of nealrichardson/httptest2#42 for you--when git clones, it inserts CRLF on Windows by default. Let's see if this fixes things.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (2ed94fb) to head (30784e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files          26       26           
  Lines        2160     2160           
=======================================
  Hits         2006     2006           
  Misses        154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmaspons jmaspons self-requested a review June 19, 2024 15:00
Copy link
Collaborator

@jmaspons jmaspons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, seems that fix the failing tests 🥳

Thank you!

It would be good to document the trick somewhere in httptest2

@jmaspons jmaspons merged commit 13fb451 into ropensci:main Jun 19, 2024
9 checks passed
@nealrichardson
Copy link
Contributor Author

Great, seems that fix the failing tests 🥳

Thank you!

It would be good to document the trick somewhere in httptest2

Yeah, agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants