Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the readme #20

Closed
jontje opened this issue Sep 6, 2018 · 5 comments
Closed

Expand the readme #20

jontje opened this issue Sep 6, 2018 · 5 comments
Assignees
Labels

Comments

@jontje
Copy link
Contributor

jontje commented Sep 6, 2018

Add sections for:

  • Structure/class descriptions
  • Troubleshooting
  • Acknowledgements
@jontje jontje added the task label Sep 6, 2018
@jontje jontje self-assigned this Sep 6, 2018
@gavanderhoorn
Copy link
Member

See my comment here: ros-industrial/abb_libegm#17 (comment).

@jontje
Copy link
Contributor Author

jontje commented Sep 6, 2018

That sounds reasonable, see my reply here ros-industrial/abb_libegm#17 (comment).

Except that the "structure/class descriptions" would be something like this for RWS:

  • Add a simple illustration of how the important classes are related to each other.
  • Add some very brief lines for each class. For example:
    • POCOClient
      Sets up, and manages a HTTP client and (if needed) a WebSocket instance (based on POCO classes)
    • RWSClient
      Expands the POCOClient for using RWS (e.g. exposing RWS services and resources, evaluating the communication results)
    • RWSInterface
      Provide more user friendly APIs (e.g. wraps a RWSClient and provide simpler methods)
    • RWSStateMachineInterface
      Extends the RWSInterface for a system specific case (i.e. requires specific configurations and RAPID program running on the robot controller)

This just so that one can get a quick overview, without digging into the details.

@jontje
Copy link
Contributor Author

jontje commented Mar 12, 2019

Regarding troubleshooting:
The readme should be update to include a description of the problem mentioned in issue #47 and the possible solution in comment #47 (comment)

@gavanderhoorn
Copy link
Member

Regarding troubleshooting:
The readme should be update to include a description of the problem mentioned in issue #47 and the possible solution in comment #47 (comment)

Tracking this outstanding task in #81 (which I believe is a nicer solution than the proxy approach described in #47 (comment)).

@gavanderhoorn
Copy link
Member

Closing, as I believe all the other additions to the readme have been made.

Further improvements can be suggested/tracked in other issues.

Thanks @jontje 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants