Added a section for usage hints, replaced an obsolete interface #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jontje
commented
Nov 28, 2018
jontje
commented
- Added brief descriptions of the library's primary classes.
- Added references to an optional RobotWare Add-In called StateMachine Add-In.
- Replaced the obsolete RWSSimpleStateMachineInterface with RWSStateMachineInterface.
- Generalized the RAPID representation with name change and added a class representing a RAPID record of type speeddata.
…, and generalized the RAPID representation
|
General comment: could I ask you to please use multiple commits for these kind of PRs? We're now changing documentation, code and build scripts in a single commit. Apart from that being not very clean, it's also logistically difficult now to revert changes to any of these categories of files without having to use tricks with the other files. If the changes were in separate commits it would be relatively trivial to manage them. Just something for the future. |
|
You are completely right, I didn't even think about that. I will remember it for the future. |
|
Should d358848 be part of a separate PR? (similar comment as in #32 (comment)). |
|
Yeah, you are right :) I was a bit hasty yesterday, I will close this PR and split it into smaller ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.