Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI job to test compilation on Windows with vcpkg #91

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Add CI job to test compilation on Windows with vcpkg #91

merged 2 commits into from
Jun 8, 2020

Conversation

gavanderhoorn
Copy link
Member

As per subject.

This is a WIP at this point, as I have no idea what I'm doing.

@gavanderhoorn gavanderhoorn marked this pull request as ready for review June 6, 2020 12:04
@gavanderhoorn gavanderhoorn requested a review from jontje June 6, 2020 12:04
@gavanderhoorn
Copy link
Member Author

@traversaro: if you could take a look as well I'd appreciate it.

@traversaro
Copy link
Contributor

@traversaro: if you could take a look as well I'd appreciate it.

As far as I can see, the script seems fine.

@gavanderhoorn
Copy link
Member Author

Thanks for the review @traversaro 👍

Now I need one from @jontje, otherwise I cannot merge.

jontje
jontje approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@jontje jontje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@gavanderhoorn gavanderhoorn merged commit 3f980c8 into master Jun 8, 2020
@gavanderhoorn gavanderhoorn deleted the add_windows_ci_job branch June 8, 2020 07:53
@gavanderhoorn
Copy link
Member Author

gavanderhoorn commented Jun 8, 2020 •
edited
Loading

Thanks for the reviews everyone.

And thanks @traversaro for the initial PR which I so shamelessly copied here ;)

@gavanderhoorn gavanderhoorn mentioned this pull request Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

@jontje jontje jontje approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavanderhoorn @traversaro @jontje