Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce overall verbosity #727

Merged

Conversation

mathias-luedtke
Copy link
Member

@mathias-luedtke mathias-luedtke commented Jul 25, 2021

  • list most commands (ici_cmd)
  • filter apt-get output (ici_filtered)
  • rename ici_run to ici_step

There is still room for improvement, but this can be optimized over time

@rhaschke: Please have a look at the new output format as this addresses your concerns about the verbosity in #452

closes #712
closes #728

includes #733 and #731

@mathias-luedtke mathias-luedtke force-pushed the fix/verbosity branch 5 times, most recently from 2e374b2 to 776b3b3 Compare July 25, 2021 20:59
@rhaschke
Copy link
Contributor

Looks good to me. But I noticed that coloring is missing for the build step, e.g. in https://github.com/ros-industrial/industrial_ci/runs/3156358865.

@mathias-luedtke
Copy link
Member Author

But I noticed that coloring is missing for the build step, e.g. in https://github.com/ros-industrial/industrial_ci/runs/3156358865.

Where exactly?

@rhaschke
Copy link
Contributor

While the output of catkin config is still colored, the output of catkin build is not.

@mathias-luedtke
Copy link
Member Author

While the output of catkin config is still colored, the output of catkin build is not.

Ah, I see. It is not running in a tty anymore, because it is piped.
For now I might take the pipe away and get rid of set -e, which does not work reliably.

@mathias-luedtke mathias-luedtke force-pushed the fix/verbosity branch 2 times, most recently from 470311a to 82d7bd9 Compare July 29, 2021 19:28
@mathias-luedtke
Copy link
Member Author

@rhaschke: please have a look again. The "industrial_ci` have traces enables, the others not.

In a follow-up PR I will make the commands top-level folds.

@mathias-luedtke mathias-luedtke merged commit e7b01f3 into ros-industrial:master Aug 1, 2021
@mathias-luedtke mathias-luedtke deleted the fix/verbosity branch August 1, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement TRACE option Silence more steps
2 participants