[abi_check] Pass quoted cflags to colcon

[aprotyas]

The colcon invocation in abi_process_workspace was only providing
the first of the two cflags, hence omitting -Og. To work around
this, the flags must be enclosed by literal quotation marks.

This commit escapes the flag specification to insert these literal
quotes around the flags.

Signed-off-by: Abrar Rahman Protyasha [email protected]

[aprotyas]

For reviewers: to verify, please run both colcon -DCMAKE_CXX_FLAGS=-g -Og and colcon -DCMAKE_CXX_FLAGS="-g -Og" for any package with the -DCMAKE_EXPORT_COMPILE_COMMANDS=ON option. This should generate a compile_commands.json containing the exact compiler calls for all translation units of the project in ros2_ws/build/pkg_name, where you can see what flags are being passed to the compiler.

[aprotyas]

Friendly ping for thoughts/review @mathias-luedtke

[mathias-luedtke]

Thank you very much!
Your patch seems to fix it.
Could you add a test as well, so that it will stay this way in the future?

[aprotyas]

@mathias-luedtke thanks for the review. I'm not sure how to test for this behavior though since its difficult to observe the abi_check interface behavior without parsing compiler command logs. Thoughts?

[mathias-luedtke]

I'm not sure how to test for this behavior though since its difficult to observe the abi_check interface behavior without parsing compiler command logs. Thoughts?

You wrote:

This should generate a compile_commands.json containing the exact compiler calls for all translation units of the project in ros2_ws/build/pkg_name

So why not just check the compile_commands.json? For example with ' grep -q`. I might add this later.