Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shallow import with VCS #842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marip8
Copy link
Member

@marip8 marip8 commented Nov 6, 2023

Changes per commit message to reduce overall setup time (and resultant docker image size) when working with large projects.

@marip8
Copy link
Member Author

marip8 commented Nov 7, 2023

Any ideas why the ABI check test fails on vcs import --recursive --force --shallow /root/base_ws/src? I don't see anywhere in the vcstool docs that says the recursive and shallow options are mutually exclusive

@mathias-luedtke
Copy link
Member

Any ideas why the ABI check test fails

That test checks the ABI against a previous commit and it does not exist in a shallow clone..

Copy link
Member

@mathias-luedtke mathias-luedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might break existing setups (just as it breaks the ABI test).
Not sure, if we should make it an opt-in or opt-out behavior..

VCS_IMPORT_SHALLOW?

It must get set to false, if ABICHECK_MERGE=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants