Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Remove spline fit and min length check from plane slice planner #271

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

marip8
Copy link
Member

@marip8 marip8 commented Oct 1, 2024

This PR updates the plane slice planner to remove the parametric spline fitting and minimum segment length checks (in favor of using modular tool path modifiers to do these tasks).

@marip8
Copy link
Member Author

marip8 commented Oct 1, 2024

TODO

  • Create minimum segment length tool path modifier
  • Resolve issue with strange generation of tool path directions seen in the image below.

plane-slice-issue
plane-slice-issue-2

@marip8 marip8 requested a review from DavidMerzJr October 1, 2024 16:03
@marip8 marip8 force-pushed the update/plane-slice-planner-remove-min-length branch from 31e3ec7 to 6349dda Compare October 1, 2024 16:27
@marrts
Copy link
Contributor

marrts commented Oct 8, 2024

Resolve issue with strange generation of tool path directions seen in the image below.

This is because they are ordered based off the direction that you specify, not necessarily the order that makes the most sense, or the shortest path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants