-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document Debian package download #518
Merged
christian-rauch
merged 7 commits into
ros-industrial:devel
from
christian-rauch:doc_deb_download
Dec 29, 2024
Merged
document Debian package download #518
christian-rauch
merged 7 commits into
ros-industrial:devel
from
christian-rauch:doc_deb_download
Dec 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d6be89
to
4602cf2
Compare
Closed
328fba7
to
71b7ee3
Compare
481676e
to
515157e
Compare
edaabee
to
da119ea
Compare
cf5a7d7
to
c3f1a04
Compare
c3f1a04
to
1269535
Compare
@Levi-Armstrong See this updated PR for a proposal on how to distribute the Debian packages to users as a replacement for your PR #517. This should prevent issues such as #521. |
Levi-Armstrong
approved these changes
Dec 25, 2024
b99e2a6
to
40fb79c
Compare
7c2c716
to
444c9c8
Compare
444c9c8
to
8cb596e
Compare
I added a GUI launcher to the Debian package with a custom script during the CPack process. Installing the plugin Debian package now will also install a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an earlier version of this PR, I proposed to download Qt Creator and the plugin from different sources using different methods. This makes it difficult to synchronise compatible Qt Creator and plugin versions.
In the new version of the PR, the CI pipeline will upload the Qt Creator Debian package, which was used to generate the plugin Debian package, as a release artifact. This makes sure that a compatible Qt Creator version is released together with the plugin on GitHub, and it allows us to use the GitHub API to download these compatible versions.