Fix downstream dependencies having to include boost thread #1
Conversation
Downstream dependencies don't know that this package depends on several boost components. Linking to socketcan_interface without specifing these components will result in a linking error. This package should correctly export its linking flags. I've followed the answer from the following post to fix this: https://answers.ros.org/question/331089/ament_export_dependenciesboost-not-working/?answer=332460#post-id-332460
|
As already explained (ros-industrial/ros_canopen#415), this repo contains an unsupported prototype. Nevertheless, I see the need to solve this issue. |
| system | ||
| thread | ||
| ) | ||
| list(APPEND pluginlib_LIBRARIES ${Boost_LIBRARIES}) |
There was a problem hiding this comment.
Why do you append to pluginlib_LIBRARIES?
There was a problem hiding this comment.
Whoops, that is left over from the code where I based this PR on. I'll clean it up
There was a problem hiding this comment.
Sorry, I missed that I was using a prototype. I'll test my hardware driver against ros-industrial/ros_canopen#364 and see how far I can come
| system | ||
| thread | ||
| ) | ||
| list(APPEND pluginlib_LIBRARIES ${Boost_LIBRARIES}) |
There was a problem hiding this comment.
Whoops, that is left over from the code where I based this PR on. I'll clean it up
|
I've retargeted the PR to mathias-luedtke/ros_canopen#4 |
Downstream dependencies don't know that this package depends on several
boost components. Linking to socketcan_interface without specifing these
components will result in a linking error. This package should correctly
export its linking flags.
I've followed the answer from the following post to fix this:
https://answers.ros.org/question/331089/ament_export_dependenciesboost-not-working/?answer=332460#post-id-332460