Skip to content

Commit

Permalink
Changelog
Browse files Browse the repository at this point in the history
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
  • Loading branch information
ahcorde committed Jun 17, 2024
1 parent dc0f791 commit 3bae4fa
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
19 changes: 19 additions & 0 deletions libcurl_vendor/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,25 @@
Changelog for package libcurl_vendor
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

3.5.1 (2024-06-17)
------------------
* Add "lib" to the Windows curl search path. (`#96 <https://github.com/ros/resource_retriever/issues/96>`_)
In CMake 3.3, a commit made it so that the find_package
module in CMake had a compatibility mode where it would
automatically search for packages in a <prefix>/lib subdirectory.
In CMake 3.6, this compatibility mode was reverted for all
platforms *except* Windows.
That means that since CMake 3.3, we haven't actually been
using the path as specified in `curl_DIR`, but we have
instead been inadvertently relying on that fallback behavior.
In CMake 3.28, that compatibilty mode was also removed for
Windows, meaning that we are now failing to find_package(curl)
in downstream packages (like resource_retriever).
Fix this by adding in the "lib" directory that always should
have been there. I'll note that this *only* affects our
Windows builds, because this code is in a if(WIN32) block.
* Contributors: Chris Lalancette

3.5.0 (2024-04-26)
------------------

Expand Down
5 changes: 5 additions & 0 deletions resource_retriever/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
Changelog for package resource_retriever
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

3.5.1 (2024-06-17)
------------------
* Allow spaces (`#100 <https://github.com/ros/resource_retriever/issues/100>`_)
* Contributors: Alejandro Hernández Cordero

3.5.0 (2024-04-26)
------------------

Expand Down

0 comments on commit 3bae4fa

Please sign in to comment.