-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an API for reading files from the RPM payload #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f908a1b
to
66d7a6f
Compare
76478d8
to
b36edcf
Compare
Here's a bit of example code for demo purposes: use rpm;
use std::env::args;
fn main() {
let rpm_path = args().nth(1).expect("provide an RPM to extract");
let package =
rpm::Package::open(rpm_path).unwrap();
let dest_path = args().nth(2).unwrap_or(package.metadata.get_name().unwrap().to_owned());
package.extract(&dest_path).unwrap();
for f in package.files().unwrap() {
let f = f.unwrap();
println!("{}", f.metadata.path.display());
}
} |
390129d
to
8ffcf4d
Compare
drahnr
reviewed
Jan 20, 2025
drahnr
reviewed
Jan 20, 2025
drahnr
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, bar some more documentation details
@drahnr I tweaked the behavior slightly such that it uses |
drahnr
reviewed
Jan 21, 2025
drahnr
reviewed
Jan 21, 2025
drahnr
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Checklist
--all-features
enabledNote: I'm working on tests, but they will be easier to merge as part of the test overhaul PR. In the meantime I did some manual testing for this PR.