Create assetStatus type as per Justin's request

rrweb-io · Apr 3, 2024 · dfcfee4 · dfcfee4
1 parent c88f8d8
commit dfcfee4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/packages/rrweb/src/record/observers/asset-manager.ts b/packages/rrweb/src/record/observers/asset-manager.ts
@@ -10,7 +10,7 @@ import { encode } from 'base64-arraybuffer';
 
 import { patch } from '../../utils';
 
-import type { recordOptions } from '../../types';
+import type { recordOptions, assetStatus } from '../../types';
 import { isAttributeCapturable, getSourcesFromSrcset } from 'rrweb-snapshot';
 
 export default class AssetManager {
@@ -126,9 +126,7 @@ export default class AssetManager {
     }
   }
 
-  public capture(asset: asset): {
-    status: 'capturing' | 'captured' | 'error' | 'refused';
-  } {
+  public capture(asset: asset): assetStatus {
     if (asset.attr === 'srcset') {
        getSourcesFromSrcset(asset.value).forEach((url) => {
         this.captureUrl(url);
@@ -138,9 +136,7 @@ export default class AssetManager {
     }
   }
 
-  public captureUrl(url): {
-    status: 'capturing' | 'captured' | 'error' | 'refused';
-  } {
+  public captureUrl(url): assetStatus {
     if (this.shouldIgnore(url)) return { status: 'refused' };
 
     if (this.capturedURLs.has(url)) {

diff --git a/packages/rrweb/src/types.ts b/packages/rrweb/src/types.ts
@@ -226,3 +226,11 @@ export type CrossOriginIframeMessageEvent =
   MessageEvent<CrossOriginIframeMessageEventContent>;
 
 export type ErrorHandler = (error: unknown) => void | boolean;
+
+export type assetStatus = {
+  status:
+    | 'capturing'
+    | 'captured'
+    | 'error'
+    | 'refused'
+};