Code

assets + stylesheet assets#1475

Code

Open

eoghanmurray wants to merge 183 commits intorrweb-io:masterrrweb-io/rrweb:masterfrom eoghanmurray:stylesheet-assetseoghanmurray/rrweb:stylesheet-assetsCopy head branch name to clipboard

+7,171-1,309

Commits

Commits on Oct 14, 2024

• Add Asset event type and capture assets

  

  Juice10

  authored and

  eoghanmurray

  committed
  2b58e8d

  Copy full SHA for 2b58e8d

• Add test to prove player works

  

  Juice10

  authored and

  eoghanmurray

  committed
  7acc779

  Copy full SHA for 7acc779

• Rename assetCaptureConfig to assetCapture

  

  Juice10

  authored and

  eoghanmurray

  committed
  608ba0e

  Copy full SHA for 608ba0e

• Document assetCapture config

  

  Juice10

  authored and

  eoghanmurray

  committed
  b20c8d5

  Copy full SHA for b20c8d5

• Create asset event for assets that failed to load

  

  Juice10

  authored and

  eoghanmurray

  committed
  ad775d8

  Copy full SHA for ad775d8

• Move types from rrweb-snapshot to @rrweb/types

  

  Juice10

  authored and

  eoghanmurray

  committed
  1294549

  Copy full SHA for 1294549

• WIP asset manager for replay

  

  Juice10

  authored and

  eoghanmurray

  committed
  0b18d21

  Copy full SHA for 0b18d21

• Add placeholder tests

  

  Juice10

  authored and

  eoghanmurray

  committed
  2a92a9f

  Copy full SHA for 2a92a9f

• Fix image source attribute in rebuild function

  

  Juice10

  authored and

  eoghanmurray

  committed
  150396a

  Copy full SHA for 150396a

• Update path in tsconfig.json

  

  Juice10

  authored and

  eoghanmurray

  committed
  4a0dd26

  Copy full SHA for 4a0dd26

• Fix asset loading in Replayer

  

  Juice10

  authored and

  eoghanmurray

  committed
  08114ee

  Copy full SHA for 08114ee

• Add todo tests

  

  Juice10

  authored and

  eoghanmurray

  committed
  bee80ed

  Copy full SHA for bee80ed

• Add asset mutation events for replayer test

  

  Juice10

  authored and

  eoghanmurray

  committed
  c65dd0d

  Copy full SHA for c65dd0d

• Add replay for cached asset on attribute changes

  

  Juice10

  authored and

  eoghanmurray

  committed
  9e5fb47

  Copy full SHA for 9e5fb47

• Fix syntax error

  

  Juice10

  authored and

  eoghanmurray

  committed
  d8ae854

  Copy full SHA for d8ae854

• Move assetCapture params to @rrweb/types and add them to meta events

  

  Juice10

  authored and

  eoghanmurray

  committed
  e2b181a

  Copy full SHA for e2b181a

• Add asset capture config to meta events

  

  Juice10

  authored and

  eoghanmurray

  committed
  a49cc54

  Copy full SHA for a49cc54

• NodeType was moved to @rrweb/types

  

  Juice10

  authored and

  eoghanmurray

  committed
  a5097a7

  Copy full SHA for a5097a7

• Upgrade jest and rollup in rrweb-snapshot

  

  Juice10

  authored and

  eoghanmurray

  committed
  f33f8ab

  Copy full SHA for f33f8ab

• Add check types

  

  Juice10

  authored and

  eoghanmurray

  committed
  dff274b

  Copy full SHA for dff274b

• Update snapshots to include assetCapture settings

  

  Juice10

  authored and

  eoghanmurray

  committed
  3802bd5

  Copy full SHA for 3802bd5

• Mark inlineImages as deprecated in favor of assetCapture

  

  Juice10

  authored and

  eoghanmurray

  committed
  5436839

  Copy full SHA for 5436839

• Fix rrdom build

  

  Juice10

  authored and

  eoghanmurray

  committed
  60d1b42

  Copy full SHA for 60d1b42

• Fix deprecated test

  

  Juice10

  authored and

  eoghanmurray

  committed
  561dcda

  Copy full SHA for 561dcda

• Rename assetCapture to captureAssets

  Show description for 973222b
  

  Juice10

  authored and

  eoghanmurray

  committed
  973222b

  Copy full SHA for 973222b

• Remove console.log statements from AssetManager

  Show description for ee56ec5
  

  Juice10

  authored and

  eoghanmurray

  committed
  ee56ec5

  Copy full SHA for ee56ec5

• Rename assetCapture to captureAssets in rrweb test

  

  Juice10

  authored and

  eoghanmurray

  committed
  e96793e

  Copy full SHA for e96793e

• Check if url is of cacheable origin

  

  Juice10

  authored and

  eoghanmurray

  committed
  15eda9b

  Copy full SHA for 15eda9b

• Test: Add captureAssets config to meta event

  

  Juice10

  authored and

  eoghanmurray

  committed
  33030bc

  Copy full SHA for 33030bc

• object urls aren't stable so lets remove them

  

  Juice10

  authored and

  eoghanmurray

  committed
  f21787b

  Copy full SHA for f21787b

• inlineImages should work next to captureAssets for now

  

  Juice10

  authored and

  eoghanmurray

  committed
  69d0ade

  Copy full SHA for 69d0ade

• Fix asset caching bug

  

  Juice10

  authored and

  eoghanmurray

  committed
  b076708

  Copy full SHA for b076708

• captureAssets on live-stream by default

  

  Juice10

  authored and

  eoghanmurray

  committed
  60b8bb1

  Copy full SHA for 60b8bb1

• Fix asset URLs in events file

  

  Juice10

  authored and

  eoghanmurray

  committed
  20cd37e

  Copy full SHA for 20cd37e

• Update deprecated inlineImages option to use

  Show description for 23f046c
  

  Juice10

  authored and

  eoghanmurray

  committed
  23f046c

  Copy full SHA for 23f046c

• Deprecate inlineImage config

  Show description for a66e901
  

  Juice10

  authored and

  eoghanmurray

  committed
  a66e901

  Copy full SHA for a66e901

• Update snapshot to reflect current captureAssets

  

  Juice10

  authored and

  eoghanmurray

  committed
  ec55646

  Copy full SHA for ec55646

• Make test less flaky

  

  Juice10

  authored and

  eoghanmurray

  committed
  3bdc6c3

  Copy full SHA for 3bdc6c3

• Cache attribute support for BODY, TABLE,

  Show description for 3f45acb
  

  Juice10

  authored and

  eoghanmurray

  committed
  3f45acb

  Copy full SHA for 3f45acb

• Remove unused 'inlineImages' option

  

  Juice10

  authored and

  eoghanmurray

  committed
  fa109af

  Copy full SHA for fa109af

• Refactor AssetManager constructor signature

  

  Juice10

  authored and

  eoghanmurray

  committed
  dcb6d87

  Copy full SHA for dcb6d87

• Remove console.log statements in asset.test.ts

  

  Juice10

  authored and

  eoghanmurray

  committed
  36dd426

  Copy full SHA for 36dd426

• Refactor reset method signature to accept optional

  Show description for 2509e61
  

  Juice10

  authored and

  eoghanmurray

  committed
  2509e61

  Copy full SHA for 2509e61

• Fix deserialized size comparison in deserializeArg

  Show description for 2d49f2a
  

  Juice10

  authored and

  eoghanmurray

  committed
  2d49f2a

  Copy full SHA for 2d49f2a

• Apply formatting changes

  

  Juice10

  authored and

  eoghanmurray

  committed
  40d0513

  Copy full SHA for 40d0513

• Fix asset manager to only load assets from

  Show description for 6201623
  

  Juice10

  authored and

  eoghanmurray

  committed
  6201623

  Copy full SHA for 6201623

• Update defaultPort in startServer function

  

  Juice10

  authored and

  eoghanmurray

  committed
  4f2c30d

  Copy full SHA for 4f2c30d

• Make test more reliable

  

  Juice10

  authored and

  eoghanmurray

  committed
  66a8438

  Copy full SHA for 66a8438

• Add failing test for src attribute

  

  Juice10

  authored and

  eoghanmurray

  committed
  f723f72

  Copy full SHA for f723f72

• Remove failed asset event

  

  Juice10

  authored and

  eoghanmurray

  committed
  0dc35d4

  Copy full SHA for 0dc35d4

• Add support for asset manager in rrdom

  Show description for a75c8c6
  

  Juice10

  authored and

  eoghanmurray

  committed
  a75c8c6

  Copy full SHA for a75c8c6

• Change asset manager path

  

  Juice10

  authored and

  eoghanmurray

  committed
  ffb6daf

  Copy full SHA for ffb6daf

• Fix import path for AssetManager in asset-unit.test.ts

  

  Juice10

  authored and

  eoghanmurray

  committed
  25184e7

  Copy full SHA for 25184e7

• Move isAttributeCacheable tests to rrweb-snapshot

  

  Juice10

  authored and

  eoghanmurray

  committed
  83a3ed1

  Copy full SHA for 83a3ed1

• Make assetManager optional

  

  Juice10

  authored and

  eoghanmurray

  committed
  be1b471

  Copy full SHA for be1b471

• upgrade rrdom-nodejs to jest 29

  

  Juice10

  authored and

  eoghanmurray

  committed
  480f99c

  Copy full SHA for 480f99c

• fixup! Upgrade jest and rollup in rrweb-snapshot

  eoghanmurray

  committed
  ba20659

  Copy full SHA for ba20659

• Update Jest and ts-jest versions to 29 in rrvideo

  

  Juice10

  authored and

  eoghanmurray

  committed
  53f448b

  Copy full SHA for 53f448b

• Following https://stackoverflow.com/a/64167731 on rebas

  eoghanmurray

  committed
  1491719

  Copy full SHA for 1491719

• Following https://stackoverflow.com/a/64167731 on rebase rrweb-io#2

  eoghanmurray

  committed
  f689be1

  Copy full SHA for f689be1

• Add esModuleInterop and allowSyntheticDefaultImports to tsconfig.json

  

  Juice10

  authored and

  eoghanmurray

  committed
  43d4256

  Copy full SHA for 43d4256

• Add support for updating srcset attribute in

  Show description for bf3e0fe
  

  Juice10

  authored and

  eoghanmurray

  committed
  bf3e0fe

  Copy full SHA for bf3e0fe

• Add support for SVG elements in AssetManager

  

  Juice10

  authored and

  eoghanmurray

  committed
  9b27177

  Copy full SHA for 9b27177

• Drop support for caching xlink:href attributes

  Show description for 0bd373c
  

  Juice10

  authored and

  eoghanmurray

  committed
  0bd373c

  Copy full SHA for 0bd373c

• Remove console.log statement in

  Show description for 6ffcc67
  

  Juice10

  authored and

  eoghanmurray

  committed
  6ffcc67

  Copy full SHA for 6ffcc67

• Linux and Mac generate slightly different screenshots

  

  Juice10

  authored and

  eoghanmurray

  committed
  04d806e

  Copy full SHA for 04d806e

• Remove syntax error

  

  Juice10

  authored and

  eoghanmurray

  committed
  6b09ff3

  Copy full SHA for 6b09ff3

• Add wait for RAF before evaluating snapshots

  

  Juice10

  authored and

  eoghanmurray

  committed
  6b9353a

  Copy full SHA for 6b9353a

• Changeset: Added support for Asset Event and capturing many

  Show description for 7b8358e
  

  Juice10

  authored and

  eoghanmurray

  committed
  7b8358e

  Copy full SHA for 7b8358e

• fixup! Add support for updating srcset attribute in AssetManager

  eoghanmurray

  committed
  b45b5cf

  Copy full SHA for b45b5cf

• Update puppeteer version in package.json

  

  Juice10

  authored and

  eoghanmurray

  committed
  ebe0d25

  Copy full SHA for ebe0d25

• Fix cross-origin iframe message forwarding test

  

  Juice10

  authored and

  eoghanmurray

  committed
  e678f46

  Copy full SHA for e678f46

• Make test more robust

  

  Juice10

  authored and

  eoghanmurray

  committed
  2181c25

  Copy full SHA for 2181c25

• Deprecate inlineImages and introduce captureAssets option

  

  Juice10

  authored and

  eoghanmurray

  committed
  548bd24

  Copy full SHA for 548bd24

• Docs: add examples to getUrlsFromSrcset

  

  Juice10

  authored and

  eoghanmurray

  committed
  968f4fe

  Copy full SHA for 968f4fe

• Revert accidental change to backToNormal

  

  Juice10

  authored and

  eoghanmurray

  committed
  6fd25a2

  Copy full SHA for 6fd25a2

• Move @rrweb/types to devDependencies for rrweb-snapshot

  

  Juice10

  authored and

  eoghanmurray

  committed
  3b8b974

  Copy full SHA for 3b8b974

• Remove console.log statements in asset-integration.test.ts

  

  Juice10

  authored and

  eoghanmurray

  committed
  eb39d08

  Copy full SHA for eb39d08

• Update packages/rrweb/src/replay/asset-manager/index.ts

  Show description for 68e7815
  

  Juice10

  and

  eoghanmurray

  committed
  68e7815

  Copy full SHA for 68e7815

• Delay call until all attributes are present on the new node, in case the AssetManager needs to interrogate other attributes to determine how to manage, e.g. <link with href depending on rel="styles…

  Show description for 4d3ba68
  eoghanmurray

  committed
  4d3ba68

  Copy full SHA for 4d3ba68

• Rename Cacheable -> Capturable

  eoghanmurray

  committed
  8ca75f8

  Copy full SHA for 8ca75f8

• Apply formatting changes

  

  Juice10

  authored and

  eoghanmurray

  committed
  8de02d1

  Copy full SHA for 8de02d1

• Apply formatting changes

  

  Juice10

  authored and

  eoghanmurray

  committed
  af547a3

  Copy full SHA for af547a3

• Apply formatting changes

  

  Juice10

  authored and

  eoghanmurray

  committed
  f9c4f6c

  Copy full SHA for f9c4f6c

• Trigger CI again

  

  Juice10

  authored and

  eoghanmurray

  committed
  00cd080

  Copy full SHA for 00cd080

• Apply formatting changes

  

  Juice10

  authored and

  eoghanmurray

  committed
  c833878

  Copy full SHA for c833878

• Need to import NodeType directly, not working after some combination of this moving location & change to vitest

  eoghanmurray

  committed
  c7eeb1e

  Copy full SHA for c7eeb1e

• Fix typo in deprecated test

  eoghanmurray

  committed
  6f02664

  Copy full SHA for 6f02664

• Make test less flaky

  

  Juice10

  authored and

  eoghanmurray

  committed
  1f55cee

  Copy full SHA for 1f55cee

• add @types/prettier dependency

  

  Juice10

  authored and

  eoghanmurray

  committed
  4d884d6

  Copy full SHA for 4d884d6

• Indicate the presence of deferred assets using new rr_captured_* attributes instead of storing config on the Meta event

  Show description for 8fc8837
  eoghanmurray

  committed
  8fc8837

  Copy full SHA for 8fc8837

• Revert attributes in non-live mode and ensure this happens when we can determine that Assets won't be arriving later

  eoghanmurray

  committed
  9556922

  Copy full SHA for 9556922

• Only record certain iframes as assets as we don't want to override the existing nested iframe mechanism

  eoghanmurray

  committed
  7c5beef

  Copy full SHA for 7c5beef

• Fixup: we don't need template strings here

  eoghanmurray

  committed
  a561c33

  Copy full SHA for a561c33

• Ensure we correctly distinguish between html <iframes> and other exotic types that inline images or pdfs

  eoghanmurray

  committed
  134374f

  Copy full SHA for 134374f

• Bump timeouts here as I was getting failures when running whole test suite concurrently

  eoghanmurray

  committed
  ed0d5ab

  Copy full SHA for ed0d5ab

• Add an asset type which includes the element; a bit of prep work for handling stylesheet assets

  eoghanmurray

  committed
  d3534be

  Copy full SHA for d3534be

• This function was replaced by getSourcesFromSrcset which ultimately derives from rrweb-io/rrweb-snapshot#74

  eoghanmurray

  committed
  8a06c49

  Copy full SHA for 8a06c49

• Refactor and prepare for some changes: Deal with the difference between srcset and other url attributes in one place

  eoghanmurray

  committed
  bb33dba

  Copy full SHA for bb33dba

• Create assetStatus type as per Justin's request

  eoghanmurray

  committed
  cae9720

  Copy full SHA for cae9720

• Fix types as per suggestions from code review

  

  Juice10

  authored and

  eoghanmurray

  committed
  e39ee96

  Copy full SHA for e39ee96

• Update packages/rrweb/src/replay/canvas/2d.ts

  

  Juice10

  authored and

  eoghanmurray

  committed
  4429182

  Copy full SHA for 4429182

• Don't rename attrs of assets which will be refused according to initial recording config, i.e. the origins don't match. Should make the 'refused' status redundant

  eoghanmurray

  committed
  2ada9a1

  Copy full SHA for 2ada9a1

• New config option inlineStylesheet='all' in order to fetch stylesheets (that are otherwise blocked due to e.g. CORs issues) as assets

  eoghanmurray

  committed
  7e17722

  Copy full SHA for 7e17722

• Simplify onAssetDetected function signature

  eoghanmurray

  committed
  77d8a83

  Copy full SHA for 77d8a83

• Don't double capture blobs as _cssText and an asset. Fixes test 'captures stylesheets with blob: url'

  eoghanmurray

  committed
  3254dec

  Copy full SHA for 3254dec

• Prefer to inlineStylesheets using Assets so that we can take advantage of requestIdleCallback and not block the main thread during snapshotting

  eoghanmurray

  committed
  f4a88f5

  Copy full SHA for f4a88f5

• No need to search through document.styleSheets as the sheet property is available https://developer.mozilla.org/en-US/docs/Web/API/HTMLLinkElement/sheet

  eoghanmurray

  committed
  1c78feb

  Copy full SHA for 1c78feb

• Improvements to comments on buildStyleNode (don't want to rebase as is on another branch)

  eoghanmurray

  committed
  bbec8e8

  Copy full SHA for bbec8e8

• Capture <style> element css via an asset event to avoid main thread processing cost during initial snapshotting

  eoghanmurray

  committed
  50d4953

  Copy full SHA for 50d4953

• Add a slight delay as per rrweb-io#1455

  eoghanmurray

  committed
  578bcdf

  Copy full SHA for 578bcdf

• Allow certain assets to be captured synchronously during mutation

  eoghanmurray

  committed
  7bc516d

  Copy full SHA for 7bc516d

• Add setting to control how quickly stylesheet assets get emitted - solves real problem in 'can record style text mutations' where we need to have the asset events emitted so that we can replay corr…

  Show description for d03a53c
  eoghanmurray

  committed
  d03a53c

  Copy full SHA for d03a53c

• Don't queue up asset callbacks twice; was happening after replayer.pause in 'can record style text mutations' test

  Show description for 3fcbc79
  eoghanmurray

  committed
  3fcbc79

  Copy full SHA for 3fcbc79

• We can rebuild styles immediately without the async/promise delay that is necessary for images. This fixes the 'can record style text mutations' test where we are scrubbing around the replayer sync…

  Show description for 396dd0c
  eoghanmurray

  committed
  396dd0c

  Copy full SHA for 396dd0c

• When we rebuild styles immediately from a snapshot, ensure we are correctly using cssTextSplits by applying to the serializedNode rather than the DOM node. Another fix the 'can record style text mu…

  Show description for 84618b7
  eoghanmurray

  committed
  84618b7

  Copy full SHA for 84618b7

• Didn't realize we can use the 'as' keyword to treat an rrdom element as a real element - otherwise rrweb-snapshot would need to import RRStyleElement which would create a cyclic dependency

  eoghanmurray

  committed
  91a1e1d

  Copy full SHA for 91a1e1d

• Fix up an issue with the assumption that origins applies only to images

  eoghanmurray

  committed
  d555c09

  Copy full SHA for d555c09

• Restore inlineImages as a first class config option which bypasses the origins mechanism to attempt to inline all images. The previous method will still be used in standalone snapshots

  eoghanmurray

  committed
  ada0769

  Copy full SHA for ada0769

• Remove tests that are duplicated minus the 'if inlineImages is on' part - they are basically testing the same thing as the iframe versions still have <img> elements. These tests were also previousl…

  Show description for 6554bf1
  eoghanmurray

  committed
  6554bf1

  Copy full SHA for 6554bf1

• Don't emit style mutations if we haven't serialized the style sheet yet - the asset event will include the final content anyway

  eoghanmurray

  committed
  a6b520b

  Copy full SHA for a6b520b

• Replicate the 'removing style elements' test but with an asset

  eoghanmurray

  committed
  8f3c65d

  Copy full SHA for 8f3c65d

• Catch and fix omission of absoluteToStylesheet processing on style text node mutations

  eoghanmurray

  committed
  eaa0f09

  Copy full SHA for eaa0f09

• Add a try/catch here as we may not be reading anchor.href

  eoghanmurray

  committed
  a912e16

  Copy full SHA for a912e16

• Explore how we capture assets that have disappeared from the DOM

  eoghanmurray

  committed
  dea66b5

  Copy full SHA for dea66b5

• Add some notes after considering changing these to use assets

  eoghanmurray

  committed
  2482503

  Copy full SHA for 2482503

• Add explanation as to why we are patching createObjectURL

  eoghanmurray

  committed
  b1e7ab4

  Copy full SHA for b1e7ab4

• Idea from Justin: Store cssText as an array rather than with the extra splits parameter when it is an asset so that there's a uniform way of processing it

  eoghanmurray

  committed
  61e5fba

  Copy full SHA for 61e5fba

• Allow usage of requestIdleCallback to be turned off altogether by setting a zero or negative value for config.processStylesheetsWithin

  eoghanmurray

  committed
  a57bc5c

  Copy full SHA for a57bc5c

• requestIdleCallback: Process inline <style> elements before <link rel="stylesheet">

  eoghanmurray

  committed
  019b44e

  Copy full SHA for 019b44e

• Simplify by passing the inlineStylesheets config setting around as part of the captureAssets config where possible

  eoghanmurray

  committed
  0a42bdc

  Copy full SHA for 0a42bdc

• These settings are not 'inlining' in the snapshot but rather producing new asset events

  eoghanmurray

  committed
  cdb2363

  Copy full SHA for cdb2363

• Transfer the legacy default setting into a special 'without-fetch' in config.stylesheets, as I want that to match inlineImages in that true will attempt to fetch all stylesheets

  eoghanmurray

  committed
  9fa0289

  Copy full SHA for 9fa0289

• Enable all capturing of stylesheets via assets to be turned off

  eoghanmurray

  committed
  433e93c

  Copy full SHA for 433e93c

• Add a setting to enable turning off of assets for smaller stylesheets (in terms of outer rules)

  eoghanmurray

  committed
  703b7f9

  Copy full SHA for 703b7f9

• Properly handle a loading CORS stylesheet as a mutation + asset rather than just an asset

  eoghanmurray

  committed
  44542a3

  Copy full SHA for 44542a3

• Rewrite of assets.md and move out of recipes into core docs

  eoghanmurray

  committed
  5ebe721

  Copy full SHA for 5ebe721

• Apply formatting changes

  eoghanmurray

  committed
  999cc32

  Copy full SHA for 999cc32

• Satisfy eslint

  eoghanmurray

  committed
  18c44eb

  Copy full SHA for 18c44eb

• Satisfy typescript by creating an Interface to acknowledge the extra synthetic property on the style element

  eoghanmurray

  committed
  92dbf7f

  Copy full SHA for 92dbf7f

• Don't just re-assert 'detected' in the explanatory comment

  eoghanmurray

  committed
  6911010

  Copy full SHA for 6911010

• Prefer waitForRAF over timeout as the latter operates in puppeteer rather than browser context

  eoghanmurray

  committed
  ed4fb11

  Copy full SHA for ed4fb11

• Update assets.zh_CN.md

  Show description for e0327f0
  

  YunFeng0817

  authored and

  eoghanmurray

  committed
  e0327f0

  Copy full SHA for e0327f0

• Remove doubly added prettier reference

  eoghanmurray

  committed
  5e43f37

  Copy full SHA for 5e43f37

• Fixup expected server url; presumably this is a side effect of switch to vite

  eoghanmurray

  committed
  ad7ce45

  Copy full SHA for ad7ce45

• Fixup test: maybe vite doesn't incorrectly produce this dupe?

  eoghanmurray

  committed
  157a256

  Copy full SHA for 157a256

• Continue fixes from rrweb-io#1510

  eoghanmurray

  committed
  6763c08

  Copy full SHA for 6763c08

• Extra pause needed after switch from jest to vitest, when running tests in parallel - not needed when running test by itself

  eoghanmurray

  committed
  6bd9b47

  Copy full SHA for 6bd9b47

• Fixups to imports; I'm not sure where this all went wrong in the rebase process

  eoghanmurray

  committed
  f3fa35d

  Copy full SHA for f3fa35d

• fixup! Caught a case where a text mutation, which bypasses _cssText, wasn't getting rebuilt with adaptCssForReplay

  eoghanmurray

  committed
  ec60cef

  Copy full SHA for ec60cef

• This was removed in single-style-capture but 'reintroduced' in this history via asset-event branch

  eoghanmurray

  committed
  2d5afc4

  Copy full SHA for 2d5afc4

• Fix that the false default on shouldIgnoreAssets should have been a true (ignore by default) - an empty (or maybe partial) captureAssets config where origins was unspecified was producing the…

  Show description for 8aa7388
  eoghanmurray

  committed
  8aa7388

  Copy full SHA for 8aa7388

• Fix that we would have tried to capture an asset with a malformed url with { origins: true }

  eoghanmurray

  committed
  c71393e

  Copy full SHA for c71393e

• Honour the 'omits css contents for asset managed stylesheet' test:

  Show description for c12e649
  eoghanmurray

  committed
  c12e649

  Copy full SHA for c12e649

• Improve consistency in terms of where in the test the asset appears

  eoghanmurray

  committed
  403313c

  Copy full SHA for 403313c

• Apply formatting changes

  eoghanmurray

  committed
  d1ca7ac

  Copy full SHA for d1ca7ac

• Prior to this PR, we weren't previously storing blank _cssText; could be a fixup to 'Capture <style> element css via an asset event...'

  eoghanmurray

  committed
  7f4aaca

  Copy full SHA for 7f4aaca

• Improve test reliability

  eoghanmurray

  committed
  3faa4de

  Copy full SHA for 3faa4de

• Think we need tighter processing for the tests to pass in the CI - presume that as the machines are quicker there, the tests complete before stylesheets are processed

  eoghanmurray

  committed
  084bf88

  Copy full SHA for 084bf88

• These tests were showing variation in CI

  eoghanmurray

  committed
  9cad5cb

  Copy full SHA for 9cad5cb

• fixup! Move types from rrweb-snapshot to @rrweb/types

  eoghanmurray

  committed
  b73ad96

  Copy full SHA for b73ad96

• fixup! Add esModuleInterop and allowSyntheticDefaultImports to tsconfig.json

  eoghanmurray

  committed
  30ffbfb

  Copy full SHA for 30ffbfb

• fixup! Move types from rrweb-snapshot to @rrweb/types

  eoghanmurray

  committed
  7a87075

  Copy full SHA for 7a87075

• Unknown changes to yarn.lock

  eoghanmurray

  committed
  27cab92

  Copy full SHA for 27cab92

• fixup! Move types from rrweb-snapshot to @rrweb/types

  eoghanmurray

  committed
  f86f182

  Copy full SHA for f86f182

• Apply formatting changes

  eoghanmurray

  committed
  c7edb29

  Copy full SHA for c7edb29

• Add a queueing mechanism so that in Live Mode we don't render full snapshots until we receive the stylesheet assets to avoid a flash of unstyled content (fouc)

  eoghanmurray

  committed
  faad2d5

  Copy full SHA for faad2d5

Commits on Oct 25, 2024

• assetCount would not suffice if multiple FullSnapshots were present in the recording, and the ordering of asset arrival in the replayer was not regular. This change also means we only wait for styl…

  Show description for 8aa60b6
  eoghanmurray

  committed
  8aa60b6

  Copy full SHA for 8aa60b6

• Satisfy typings

  eoghanmurray

  committed
  8f82519

  Copy full SHA for 8f82519

• Apply formatting changes

  eoghanmurray

  committed
  b42878b

  Copy full SHA for b42878b

• Mark where I think the assetManager resets were supposed to happen as I'm about to remove the reset in favour of keeping assets around

  eoghanmurray

  committed
  ab90b43

  Copy full SHA for ab90b43

• More accurate setting of 'allAdded' based on how asset urls compare to that specified in the full snapshot

  eoghanmurray

  committed
  ba28b86

  Copy full SHA for ba28b86

• Allow duplicate assets to only be sent once per recording (e.g. in a multi-page session).

  Show description for b130837
  eoghanmurray

  committed
  b130837

  Copy full SHA for b130837

• buildNodeWithSN still lives in rrweb-snapshot - correction for 'Move types from rrweb-snapshot to @rrweb/types' but I don't know why it wasn't needed before

  eoghanmurray

  committed
  08415f4

  Copy full SHA for 08415f4

Commits on Nov 29, 2024

• Fixup test: this test doesn't use the stylesheet assets so make sure that we don't delay fullsnapshot rendering awaiting for them

  eoghanmurray

  committed
  e41dd59

  Copy full SHA for e41dd59

• Fixup test, there's no significance in asset ordering

  eoghanmurray

  committed
  274a575

  Copy full SHA for 274a575

• Store the full URL for <style> assets as from a backend point of view it's important to distinguish between the first style element on one page, and the first style element on another page (which w…

  Show description for 557f5e5
  eoghanmurray

  committed
  557f5e5

  Copy full SHA for 557f5e5

• The allAdded flag no longer made sense in the context of multiple fullsnapshots. I don't fully understand the reason for returning the failed status; have copied over the commit message (from w…

  Show description for 7c219d8
  eoghanmurray

  committed
  7c219d8

  Copy full SHA for 7c219d8

• Guard against scenarios where preloadAllAssets is not called (came up in "should be able to modify a node's attribute once asset is loaded" test)

  eoghanmurray

  committed
  e8a9b4a

  Copy full SHA for e8a9b4a

• Fix for 'should list original url in non-live mode when asset never gets loaded' - I believe this change is needed after the change to always storing the src in rr_captured_src, but I'm unsure …

  Show description for 654e512
  eoghanmurray

  committed
  654e512

  Copy full SHA for 654e512

• This was failing again, so have reverted

  eoghanmurray

  committed
  8d01e6e

  Copy full SHA for 8d01e6e

• Don't capture small stylesheets as assets as timing issues are causing nondeterminism in the test (e.g. in 'should nest record iframe' between the emission of the iframe and emission of the style a…

  Show description for 487b920
  eoghanmurray

  committed
  487b920

  Copy full SHA for 487b920

Commits on Dec 2, 2024

• Ensure blocking class is respected to prevent processing of assets

  eoghanmurray

  committed
  1647e05

  Copy full SHA for 1647e05