-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/workaround iframe parent #1624
base: master
Are you sure you want to change the base?
Conversation
…a document to a non iframe
🦋 Changeset detectedLatest commit: acf9fbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There are failing tests there and I believe the changeset has broken something (rather than it being flaky tests) |
@salomita Can you please add a change set to the PR https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md |
Added more information, let me know if I should add more |
This is a workaround to avoid the replayer crashing when there's an error when trying to attach a #document to a non-iframe.
The replayer has a bug in which all the recording looks blank. This has been reported a couple of times:
#1414
#1619
It is happening because the replayer is trying to appendChild(#document) onto a non-iframe. The workaround prevents it from doing it and prevents the replay from going blank. Still, this is a workaround and further investigation is needed to check if the event is corrupted or if there's a mismatch in the order