Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/workaround iframe parent #1624

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

salomita
Copy link

@salomita salomita commented Jan 13, 2025

This is a workaround to avoid the replayer crashing when there's an error when trying to attach a #document to a non-iframe.

The replayer has a bug in which all the recording looks blank. This has been reported a couple of times:
#1414
#1619

It is happening because the replayer is trying to appendChild(#document) onto a non-iframe. The workaround prevents it from doing it and prevents the replay from going blank. Still, this is a workaround and further investigation is needed to check if the event is corrupted or if there's a mismatch in the order

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: acf9fbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
rrweb Patch
rrweb-snapshot Patch
rrdom Patch
rrdom-nodejs Patch
rrweb-player Patch
@rrweb/all Patch
@rrweb/replay Patch
@rrweb/record Patch
@rrweb/types Patch
@rrweb/packer Patch
@rrweb/utils Patch
@rrweb/web-extension Patch
rrvideo Patch
@rrweb/rrweb-plugin-console-record Patch
@rrweb/rrweb-plugin-console-replay Patch
@rrweb/rrweb-plugin-sequential-id-record Patch
@rrweb/rrweb-plugin-sequential-id-replay Patch
@rrweb/rrweb-plugin-canvas-webrtc-record Patch
@rrweb/rrweb-plugin-canvas-webrtc-replay Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eoghanmurray
Copy link
Contributor

There are failing tests there and I believe the changeset has broken something (rather than it being flaky tests)

@salomita salomita marked this pull request as ready for review January 14, 2025 16:01
@YunFeng0817
Copy link
Member

@salomita Can you please add a change set to the PR https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md
The workaround looks good. Can you just give us more information about this case?
For example, what is the case you encountered and is it a bug on the recorder side or a corner case that needs to be handled on the replayer side?

@salomita
Copy link
Author

@salomita Can you please add a change set to the PR https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md The workaround looks good. Can you just give us more information about this case? For example, what is the case you encountered and is it a bug on the recorder side or a corner case that needs to be handled on the replayer side?

Added more information, let me know if I should add more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants