Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input_check_buttons() and input_radio_buttons() #485

Closed
wants to merge 4 commits into from

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Feb 10, 2023

Minimal example:

shinyApp(
    page_fluid(input_check_buttons("foo", c("a", "b", "c"))), 
    function(input, output) { observe(print(input$foo))}
)

This incorporates #484, basically just for documentation purposes (#484 should probably also get merged first).

TODO

  • Move inst/component/toggle-buttons.js to TypeScript (i.e., srcts)
  • Provide a more scalable layout approach (i.e., grid layout, or even layout_column_wrap()?)
  • Should these inputs work without Shiny?
  • Is this hack still needed? Or did Bootstrap 5.2 fix the situation?

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2023

CLA assistant check
All committers have signed the CLA.

#'
#' Use `input_check_buttons()` if multiple choices may be selected at once; otherwise, use `input_radio_buttons()`
#'
#' @inheritParams input_check_search
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy over the relevant params from #484

@cpsievert
Copy link
Collaborator Author

Closing in favor of https://github.com/rstudio/bslib/pull/797/files

@cpsievert cpsievert closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants