Support custom highlight theme in other formats #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with different supportted value for PDF and HTML
[skip ci]
cderv
commented
Jan 14, 2022
R/pandoc.R
Outdated
Comment on lines
609
to
615
| is_supported <- TRUE | ||
| # for backward compatibility, partial match still need to work | ||
| highlight <- tryCatch( | ||
| error = function(e) { is_supported <<- FALSE; highlight }, | ||
| match.arg(highlight, supported) | ||
| ) | ||
| if (is_supported) return(highlight) |
There was a problem hiding this comment.
I did this change to bring back the partial matching feature that was there when match.arg() was used. Meaning
this would work.
output:
html_document:
highlight: breezIt was not following my other PR.
Comment on lines
+631
to
+641
| highlight <- custom[[highlight]] %||% highlight | ||
| # Check for extension or give informative error otherwise | ||
| if (!identical(xfun::file_ext(highlight), "theme")) { | ||
| msg <- c( | ||
| sprintf("`highlight` argument must be one of %s", | ||
| knitr::combine_words(c(supported, names(custom)), and = " or ", before = "`")), | ||
| " or a file with extension `.theme`." | ||
| ) | ||
| stop(msg, call. = FALSE) | ||
| } | ||
| highlight |
There was a problem hiding this comment.
I then added that to throw early a useful message if the highlight value is not one of the expected (either one supported theme or a file path to a .theme file).
This makes code less simple than in the other PR but it brings back useful message.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #1941 by adding support for custom highlight
.themefile in other format like PDFthis will close #2035
It uses the same internal function as previous PR to support HTML but added a logic for non HTML format too.
I also brought back backward compatibility for partial matching of Pandoc's style name are
match.argwas used before and also took the opportunity to add informative error message if unknown value is provided in order to error from R and not from Pandoc