Correctly avoid writing to the input file when there are no preserved HTML chunks #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… character vector: https://github.com/rstudio/htmltools/blob/a8a3559edbfd9dda78418251e69273fa9dfeb9bc/R/tags.R#L1581-L1583 so we need to compare the collapsed version vs the extracted value later in identical()
|
The GHA failures seem to be due to the withr binary package. |
|
I'll have a look - withr 3.0.0 was just release yesterday - so maybe some issues with the binary available for installation 🤔 |
|
Created a unit-test with an example code that triggered the error. Unfortunately, since I don't have write access, this is now in a new pull request: |
Co-authored-by: Yihui Xie <[email protected]>
…ss .md/.markdown files)
|
@cderv The withr issue is gone now. @J-Moravec Thanks for adding the test! |
|
Thanks for a quick fix and for creating many packages that hugely improved the replicability not just in science @yihui ! |
yihui
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2534:
htmltools::extractPreserveChunks()will collapse the input character vector: https://github.com/rstudio/htmltools/blob/a8a3559edbfd9dda78418251e69273fa9dfeb9bc/R/tags.R#L1581-L1583 so we need to compare the collapsed version vs the extracted value later inidentical().