-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pak
when package installation is not found
#284
Draft
schloerke
wants to merge
32
commits into
rstudio:main
Choose a base branch
from
schloerke:pak
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Standardize on OS_CODENAME instead of OS_DISTRIBUTION update the CHANGELOG.md to reflect removed packages our base images no longer need extra things installed for rPython to work. neither focal nor xenial need this installed for this package to work remove vivid/trusty/precise, only worry about xenial and focal PR feedback rcbc has some different install requirements, and also needs -y in the install step. It was never actually doing anything fix openbabel for focal, requires libeigen3-dev, which is a source package only on focal... python-software-properties doesn't exist in focal it seems do not support docxtractr on focal on travis this is prompting for user input, make sure it doesn't hopeful changelog updates add focal Dockerfile, and change Makefile to have focal tests instead of bionic still not working for focal update packages to support focal Update CHANGELOG.md add support for focal to animation add focal dockerfile and update the makefile to support it. Remove bionic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234
This PR is to get the conversation going to hopefully remove maintenance requirements of shinyapps.io by offloading to
pak
which uses RSPM to query rstudio/r-system-requirementsBenefits:
Setup:
pak
is used.pak
. Instead, it uses the hosted version provided by RStudio'sr-lib
team. This is done to update rapidly as bug fixes are found. I'd recommend moving to a CRAN installation once the dev version makes it to CRAN.rgl
originally only wanted to installlibgl1-mesa-dev
andlibgl-mesa-dev
, wherepak
says it requires:Alterations:
sodium
, I did not remove their install script.Future:
Game plan moving forward. I'd recommend spamming the few handful of authors for packages like
av
which require system installations, but do not report them so thatrstudio/r-system-requirements
picks them up automatically. (Curious as to whyav
by Jeroen doesn't have anypak
sys reqs when itsSystemRequirements
looks like:FFmpeg (>= 3.2); with at least libx264 and lame (mp3) drivers. Debian/Ubuntu:libavfilter-dev, Fedora/CentOS: ffmpeg-devel (via https://rpmfusion.org), MacOS Homebrew: ffmpeg.
)pak
system requirements for existing packagesubuntu 16.04 sys requirements
ubuntu 18.04 sys requirements
ubuntu 20.04 sys requirements
GitHub Actions Testing
Testing all packages on focal and xenial. Packages that have an install file will use it, otherwise
pak
will be used.https://github.com/schloerke/shinyapps-package-dependencies/runs/2143004651?check_suite_focus=true
cc @samperman