Install Chrome for chromote
#302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Romain Lesur <[email protected]>
…record purposes only
|
Thanks @schloerke ! I think Chrome is also better. PR #291 made the change from Chromium to Chrome for the need of pagedown printing. It is the same install file between both. |
This was referenced Jul 13, 2021
|
I've made a PR rstudio/r-system-requirements#87 that will install Google Chrome if To pair with that PR, it seems fair to keep the I'd like to keep the |
schloerke
commented
Jul 15, 2021
|
Validation on local check:
|
|
schloerke
commented
Jul 15, 2021
|
I am getting the error below when trying to use I ain't using curl package as I thought it's not required for latest version of chromote. |
|
Until this PR is merged (and implemented), you'll need to |
kippandrew
reviewed
Dec 14, 2021
| @@ -7,16 +7,16 @@ R_VERSION := 4.0.4 | |||
| docker-build-%: | |||
| docker build -t rstudio/shinyapps-package-dependencies:$* --build-arg R_VERSION=$(R_VERSION) -f Dockerfile.$* . | |||
|
|
|||
| test-xenial-%: | |||
| test-xenial-%: test install Dockerfile.xenial | |||
There was a problem hiding this comment.
Can you explain the context for these Makefile changes?
There was a problem hiding this comment.
I can't. Reverting
There was a problem hiding this comment.
jk. I can.
From deaa12, I added that if ./test file, ./install file, or Dockerfile.xenial changed, then it would be nice if the method would run again.
When running locally, the command wouldn't do anything if it a successful completion. Now, if any of those files changes, it is forced to run again.
|
Friendly ping to have this merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently making this a draft PR to post the code for internal questions until a{chromote}PR is merged into master.Question:
@cderv
Chromium focal installation related links:
debtosnap: https://ubuntu.com/blog/chromium-in-ubuntu-deb-to-snap-transition