Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install bedtools #375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

roniweiss12
Copy link

No description provided.

@roniweiss12 roniweiss12 requested a review from a team as a code owner April 4, 2024 17:41
Copy link
Contributor

@stevenolen stevenolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please take a look at my comments and let us know when you're ready for a re-review!

set -x
set -e

sudo apt-get install -y bedtools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a final newline?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of this directory should actually be the name of an R package which depends on bedtools' use to be functional as this command will only be executed when that package is in your application's dependency list. A quick cran search makes it appear that maybe bedr makes use of bedtools? How are you looking to use bedtools?

if (length(is_bedtools_installed) == 0) {
print("bedtools is not installed.")
} else {
print("bedtools is installed.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as related to the overall comment of the directory name being incorrect -- tests tend to install the related R package (and run a function which tests that the dependent system package is installed).

Consider rpoppler.

Additionally, you'll want this script to exit non-zero if the dependency is not resolved -- calling stop() instead of print() is one one such way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants