-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial vtx support (IRC Tramp) #164
base: master
Are you sure you want to change the base?
Conversation
Cool :)
|
All done, I will try to test Tramp in the weekend.. |
@bsvdoom looks perfect, let me know about test results, thanks a lot :) |
@rtlopez so I've tested it, and it does not work. Any ideas, why the values mismatch? I could not set the stop bits to 2, but I doubt that is the error. |
@bsvdoom I think that logic analyzer decoded frames incorrectly, trace looks fine for me. I have no idea why this happens, but options presented on screenshot do not match setting in code. However I compared your implementation with BF, and see some major diferrences
Can you tell which specification or implementation did you based on? |
@bsvdoom small update, in previous comment I referenced probably dead code. Actuall implementation is here https://github.com/betaflight/betaflight/blob/master/src/main/io/vtx_tramp.c#L143, nevertheless looks identical. |
This PR is based on #159 , adding support for the VTX IRC Tramp protocol.
I could not test it yet, and I need some help first:
-Please review
-How and where to set the _model.config.vtx.protocol from the MSP Ports page?
-Other functions seems to work, but not tested
-Can we move this to optionally use SOFTSERIAL? GPS is better on UART IMO.