Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE8 translated content not being removed. #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxpeterson
Copy link
Contributor

In IE8 the old translated content is not removed by $animate.leave. The result is that the element ends up containing both the original content and the translated content.

Adding the $compile ensures the content is removed.

In IE8 the old translated content is not removed by `$animate.leave`.
Adding the `$compile` ensures the content is removed.
@maxpeterson
Copy link
Contributor Author

@rubenv any thoughts on this. It is a very easy fix however I am not sure why this works / is required in IE8. Hopefully you can reproduce it when you have time to look at IE8 issues.

@rubenv rubenv modified the milestone: 2.0 Dec 8, 2014
@rubenv
Copy link
Owner

rubenv commented Dec 8, 2014

Do you have an example of how I can trigger this bug?

The thing is: I don't see this behavior, IE8 correctly removes content for me.

I'm hesitant to ship this patch as compiling is a heavy operation, so while it's just a single line of code, it has a very real impact on what happens on the page, for all users. It shouldn't be needed to have this line, so it might be a different bug.

Could you provide me with a jsFiddle example?

@rubenv rubenv removed this from the 2.0 - Contexts + IE8 milestone Jan 5, 2015
@rubenv
Copy link
Owner

rubenv commented Jan 5, 2015

Removing from milestone since we cannot reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants