Skip to content

Fix Rails/TimeZone cop error on invalid string literal encoding #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viralpraxis
Copy link
Contributor

In some cases (e.g. for testing purposes) we might to want to use invalid string literal -- in that case IMO we should not register an offense.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

In some cases (e.g. for testing purposes) we might to want
to use invalid string literal -- in that case IMO we should
not register an offense.
@@ -135,7 +135,7 @@ def check_time_node(klass, node)
end

def attach_timezone_specifier?(date)
date.respond_to?(:value) && TIMEZONE_SPECIFIER.match?(date.value.to_s)
date.respond_to?(:value) && (!date.value.to_s.valid_encoding? || TIMEZONE_SPECIFIER.match?(date.value.to_s))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just my two cents:

Suggested change
date.respond_to?(:value) && (!date.value.to_s.valid_encoding? || TIMEZONE_SPECIFIER.match?(date.value.to_s))
return false unless date.respond_to?(:value)
!date.value.to_s.valid_encoding? || TIMEZONE_SPECIFIER.match?(date.value.to_s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants