Remove RSpec/Capybara/FeatureMethods

Fix: #1852
rubocop · May 3, 2024 · ca1b356 · ca1b356
1 parent 0d51335
commit ca1b356
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 267 deletions.
diff --git a/config/default.yml b/config/default.yml
@@ -298,8 +298,15 @@ RSpec/DescribedClassModuleWrapping:
 RSpec/Dialect:
   Description: Enforces custom RSpec dialects.
   Enabled: false
-  PreferredMethods: {}
+  PreferredMethods:
+    background: before
+    scenario: it
+    xscenario: xit
+    given: let
+    given!: let!
+    feature: describe
   VersionAdded: '1.33'
+  VersionChanged: "<<next>>"
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Dialect
 
 RSpec/DuplicatedMetadata:
@@ -1018,14 +1025,6 @@ RSpec/Capybara/CurrentPathExpectation:
   VersionChanged: '2.0'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation
 
-RSpec/Capybara/FeatureMethods:
-  Description: Checks for consistent method usage in feature specs.
-  Enabled: true
-  EnabledMethods: []
-  VersionAdded: '1.17'
-  VersionChanged: '2.0'
-  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/FeatureMethods
-
 RSpec/Capybara/MatchStyle:
   Description: Checks for usage of deprecated style methods.
   Enabled: pending

diff --git a/config/obsoletion.yml b/config/obsoletion.yml
@@ -34,3 +34,9 @@ renamed:
   RSpec/Rails/MinitestAssertions: RSpecRails/MinitestAssertions
   RSpec/Rails/NegationBeValid: RSpecRails/NegationBeValid
   RSpec/Rails/TravelAround: RSpecRails/TravelAround
+
+removed:
+  RSpec/Capybara/FeatureMethods:
+    reason: >
+      this cop has migrated to `RSpec/Dialect`. Please use `RSpec/Dialect` instead.
+      in .rubocop.yml file, enable `RSpec/Dialect`.
diff --git a/lib/rubocop/cop/rspec/capybara/feature_methods.rb b/lib/rubocop/cop/rspec/capybara/feature_methods.rb
diff --git a/lib/rubocop/cop/rspec_cops.rb b/lib/rubocop/cop/rspec_cops.rb
@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require_relative 'rspec/capybara/current_path_expectation'
-require_relative 'rspec/capybara/feature_methods'
 require_relative 'rspec/capybara/match_style'
 require_relative 'rspec/capybara/negation_matcher'
 require_relative 'rspec/capybara/specific_actions'

diff --git a/spec/rubocop/cop/rspec/capybara/feature_methods_spec.rb b/spec/rubocop/cop/rspec/capybara/feature_methods_spec.rb