Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Avoid confusion with be_truthy, etc. #1706

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

bquorning
Copy link
Collaborator

@bquorning bquorning commented Sep 4, 2023

Re. https://github.com/rubocop/rubocop-rspec/pull/1682/files#r1288676048


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning requested review from ydah and pirj September 4, 2023 15:44
@bquorning bquorning mentioned this pull request Sep 4, 2023
12 tasks
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bquorning bquorning merged commit 041b1e6 into master Sep 4, 2023
22 checks passed
@bquorning bquorning deleted the clarify-eq-cop-documentation branch September 4, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants