Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error when using inherit_gem: rubocop-rspec: config/default.yml #1710

Closed
wants to merge 1 commit into from

Conversation

ydah
Copy link
Member

@ydah ydah commented Sep 11, 2023

Fix: #1698 (comment)

Once we delete it from config/obsoletion.yml, because it is an error if it is a split.

How about proceeding as follows?

  • Remove the configuration from config/obsoletion.yml once, since split would result in an error. (Patch version release)
  • Release a version that warns if RSpec/FilePath is used (Next and subsequent releases)
  • Remove RSpec/FilePath in the next major version update

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah requested a review from a team September 11, 2023 04:13
@pirj
Copy link
Member

pirj commented Sep 11, 2023

See the discussion in the comment thread.

@pirj pirj closed this Sep 11, 2023
@ydah ydah deleted the fix-error branch September 11, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants