Skip to content

Commit

Permalink
add spec Warning[category] = true|false to emit/suppress warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
lxxxvi committed Oct 22, 2020
1 parent 2642d55 commit 5ecf14f
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 1 deletion.
14 changes: 14 additions & 0 deletions core/warning/element_reference_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
require_relative '../../spec_helper'

ruby_version_is '2.7' do
describe "Warning.[]" do
it "returns default values for categories :deprecated and :experimental" do
Warning[:deprecated].should == true
Warning[:experimental].should == true
end

it "raises for unknown category" do
-> { Warning[:noop] }.should raise_error(ArgumentError, /unknown category: noop/)
end
end
end
27 changes: 27 additions & 0 deletions core/warning/element_set_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
require_relative '../../spec_helper'

ruby_version_is '2.7' do
describe "Warning.[]=" do
it "sets new values for categories :deprecated and :experimental" do
Warning[:deprecated] = false
Warning[:deprecated].should == false

Warning[:experimental] = false
Warning[:experimental].should == false
end

it "raises for unknown category" do
-> { Warning[:noop] = false }.should raise_error(ArgumentError, /unknown category: noop/)
end

it "emits and suppresses warnings for :deprecated" do
ruby_exe('Warning[:deprecated] = true; $; = ""', args: "2>&1").should =~ /is deprecated/
ruby_exe('Warning[:deprecated] = false; $; = ""', args: "2>&1").should == ""
end

it "emits and suppresses warnings for :experimental" do
ruby_exe('Warning[:experimental] = true; 0 in a', args: "2>&1").should =~ /is experimental/
ruby_exe('Warning[:experimental] = false; 0 in a', args: "2>&1").should == ""
end
end
end
1 change: 0 additions & 1 deletion core/warning/warn_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ def Warning.warn(msg)
end
end


ruby_version_is '3.0' do
it "is called by Kernel.warn with nil category keyword" do
Warning.should_receive(:warn).with("Chunky bacon!\n", category: nil)
Expand Down

0 comments on commit 5ecf14f

Please sign in to comment.