Update rubocop, replace custom cop with official safe navigator cop #5292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5292 +/- ##
==========================================
+ Coverage 96.88% 97.01% +0.13%
==========================================
Files 457 456 -1
Lines 9576 9563 -13
==========================================
Hits 9278 9278
+ Misses 298 285 -13 ☔ View full report in Codecov by Sentry. |
martinemde
force-pushed
the
martinemde/update-rubocop
branch
from
5648229
to
c72d751
Compare
martinemde
commented
Dec 1, 2024
| def default(rubygem: Rubygem.first!, # rubocop:disable Metrics/ParameterLists | ||
| number: "1.0.0", platform: "ruby", | ||
| version_gid: rubygem.versions.where(number:, platform:).first&.to_gid, | ||
| pushed_by: "Pusher", actor_gid: version_gid&.find&.pusher&.to_gid) |
There was a problem hiding this comment.
Safe navigation rubocop complained about this chain, so I extracted this into the body in each of the 3 previews so it could pass.
martinemde
force-pushed
the
martinemde/update-rubocop
branch
from
c72d751
to
8b3ec68
Compare
segiddins
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.