Enable HSTS for subdomains #5295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes TOB-RGM-4 Signed-off-by: Samuel Giddins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5295 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 457 457
Lines 9564 9564
=======================================
Hits 9291 9291
Misses 273 273 ☔ View full report in Codecov by Sentry. |
|
@segiddins are you 100% sure we need this on root domain? |
|
it's what the recommendation on the finding was |
martinemde
approved these changes
Dec 2, 2024
|
@simi what problem are you concerned may happen? I can't imagine any subdomain of rubygems accepting http traffic and not wanting to upgrade it to https. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TOB-RGM-4
Signed-off-by: Samuel Giddins [email protected]