Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM2: Partially support parentAllowsChild when domains match #19521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrian17
Copy link
Collaborator

Partially addresses #14455 .

The window now kinda works, though it's slow, leaks memory (known unload() issues) and sometimes hangs after throwing:

2025-02-14T22:19:50.642618Z ERROR ruffle_core::avm2::events: Error dispatching event EventObject { type: "getUserEnvironment", class: src.com.gaiaonline.FishTank.events::DataConnectorEvent, ptr: 0x2a5c77646f0 } to handler FunctionObject(FunctionObject { ptr: 0x2a5c5b73e00, name: "src.com.gaiaonline.FishTank.services::SpecialEventManager/onGetSettings()" }) : TypeError: Error #1010: A term is undefined and has no properties. (accessing field: events)
        at src.com.gaiaonline.FishTank.services::SpecialEventManager/onGetSettings()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at src.com.gaiaonline.FishTank.services::DataConnector/onGSILoaded()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at com.gaiaonline.gsi::GSIGateway/onComplete()
2025-02-14T22:19:50.642730Z ERROR ruffle_core::avm2::events: Error dispatching event EventObject { type: "getUserEnvironment", class: src.com.gaiaonline.FishTank.events::DataConnectorEvent, ptr: 0x2a5c77646f0 } to handler FunctionObject(FunctionObject { ptr: 0x2a5c5b76800, name: "FishTank/onUserEnvironment()" }) : TypeError: Error #1010: A term is undefined and has no properties. (accessing field: user_id)
        at FishTank/onUserEnvironment()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at src.com.gaiaonline.FishTank.services::DataConnector/onGSILoaded()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at com.gaiaonline.gsi::GSIGateway/onComplete()
2025-02-14T22:19:50.642782Z ERROR ruffle_core::avm2::events: Error dispatching event EventObject { type: "getUserEnvironment", class: src.com.gaiaonline.FishTank.events::DataConnectorEvent, ptr: 0x2a5c77646f0 } to handler FunctionObject(FunctionObject { ptr: 0x2a5c5b77900, name: "src.com.gaiaonline.FishTank.miniGames::GameManager/onUserEnvironment()" }) : TypeError: Error #1010: A term is undefined and has no properties. (accessing field: game_info)
        at src.com.gaiaonline.FishTank.miniGames::GameManager/onUserEnvironment()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at src.com.gaiaonline.FishTank.services::DataConnector/onGSILoaded()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at com.gaiaonline.gsi::GSIGateway/onComplete()

@torokati44 torokati44 added A-avm2 Area: AVM2 (ActionScript 3) T-fix Type: Bug fix (in something that's supposed to work already) labels Feb 19, 2025
@adrian17 adrian17 requested a review from kjarosh February 20, 2025 18:19
Copy link
Member

@kjarosh kjarosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) T-fix Type: Bug fix (in something that's supposed to work already)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants