DRAFT: avm1/avm2: Change TDisplayObject::object1/2 return type to Option<Object>
#19522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
added
A-avm2
Add `avm1::Value::{or_null, or_undef}` to make dealing with the
optionality more palatable.
Add `avm2::Value::or_null` to make dealing with the optionality more palatable.
moulins
force-pushed
the
display-object-opt-avm-objects
branch
from
56b4ad6 to
04327a1
Compare
moulins
changed the title
TDisplayObject::object1/2 return type to Option<Object>TDisplayObject::object1/2 return type to Option<Object>
kjarosh
added
A-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TDisplayObject::objecttoobject1, for better symmetry withobject2;Option<Object>instead ofValuefrom these methods, to better reflect what's actually allowed;Value::{or_null, or_undef}helper constructors.