Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update gRPC to 1.43.0 or greater #179

Closed
rdesgroppes opened this issue Feb 18, 2022 · 2 comments · Fixed by #178
Closed

Please update gRPC to 1.43.0 or greater #179

rdesgroppes opened this issue Feb 18, 2022 · 2 comments · Fixed by #178
Labels
dependencies Pull requests that update a dependency file resolved-next-release Code to resolve issue is pending release

Comments

@rdesgroppes
Copy link

rdesgroppes commented Feb 18, 2022 •
edited
Loading

Description

Thanks for considering updating gRPC to version 1.43.0 or greater.

A few rationales why:

  • gRPC Core 1.43.0 fixes out-of-order delivery of XdsClient watcher notifications,
  • gRPC Java 1.43.0 fixes a NullPointerException with sensus as well as the way XdsServer handles some configurations,
  • gRPC Java 1.43.1 fixes a StatusRuntimeException: INTERNAL: Panic! This is a bug! when calling ManagedChannel.enterIdle,
  • Apache Beam 2.36.0 depends on gRPC Java 1.43.2, which leads us to manually resolve (strict) dependency conflicts (side note: Apache Beam 2.37.0 will add Java 17 support for Dataflow, so keeping up with is important to us).
@hankfanchiu
Copy link

Could we upgrade gRPC to 1.44.0?

grpc/grpc#28406 (not listed in the release notes) is a nice fix for Bazel.

@aaliddell
Copy link
Member

I’ll be jumping to the latest version of all the dependencies in #178

@aaliddell aaliddell added the dependencies Pull requests that update a dependency file label Mar 27, 2022
@aaliddell aaliddell added the resolved-next-release Code to resolve issue is pending release label Aug 23, 2022
@aaliddell aaliddell mentioned this issue Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file resolved-next-release Code to resolve issue is pending release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Next Release 4.2.0 rules-proto-grpc/rules_proto_grpc
3 participants
@rdesgroppes @aaliddell @hankfanchiu