Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Release 4.2.0 #178

Merged
merged 127 commits into from
Aug 24, 2022
Merged

Next Release 4.2.0 #178

merged 127 commits into from
Aug 24, 2022

Conversation

@dnkoutso
Copy link
Contributor

Hi there! Any luck on pushing this release forward? thank you in advance!

This is required for a protoc compiled with MinGW, which has a dependency on C:\msys64\mingw64\bin\libstdc++-6.dll and thus requires C:\msys64\mingw64\bin to be in the PATH.
@aaliddell aaliddell changed the title Next Release (TBD Version) Next Release 4.2.0 Mar 27, 2022
aaliddell and others added 17 commits March 27, 2022 21:38
Set use_built_in_shell_environment default to True
Bump version of github.com/envoyproxy/protoc-gen-validate.

Without this update, passing a `go_validate_library` to a `gopath` rule gives the error:

```
foo/bar.proto: is a proto3 file that contains optional fields, but code generator protoc-gen-validate_go_plugin hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.--validate_go_plugin_out: 
```

Adding `--validate_go_plugin_out` to `extra_protoc_args` doesn't fix the issue. But this patch does.
@github-actions github-actions bot added lang-csharp C# rules specific lang-fsharp F# rules specific labels Aug 23, 2022
@dnkoutso
Copy link
Contributor

Been watching progress on this! Thank you for pushing it forward!!

@aaliddell aaliddell marked this pull request as ready for review August 24, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation lang-buf Buf rules specific lang-cpp C++ rules specific lang-csharp C# rules specific lang-doc Doc rules specific lang-fsharp F# rules specific lang-go Go rules specific lang-grpc-gateway grpc-gateway rules specific lang-js JavaScript rules specific lang-objc Objective-C rules specific lang-php PHP rules specific lang-python Python rules specific lang-ruby Ruby rules specific lang-rust Rust rules specific lang-scala Scala rules specific
Projects
None yet