Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.4.0 Release #244

Merged
merged 23 commits into from
May 3, 2023
Merged

4.4.0 Release #244

merged 23 commits into from
May 3, 2023

Conversation

aaliddell
Copy link
Member

@aaliddell aaliddell commented Jan 15, 2023 •
edited
Loading

@github-actions github-actions bot added documentation Improvements or additions to documentation lang-python Python rules specific labels Jan 15, 2023
@ClintLiddick
Copy link

Tested in a private repository that was seeing the same error on GitHub Actions windows-latest runner with Bazel 5.3.1, and the error appears to be resolved with this branch.

@gonzojive
Add bzl_library build targets.
1ff4d46 
The targets seem to be required for using "stardoc_with_diff_test" in
rules_ts_proto.
@zpervan zpervan mentioned this pull request Feb 16, 2023
Open
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Mar 5, 2023
@github-actions github-actions bot added the lang-d D rules specific label Mar 5, 2023
aaliddell and others added 3 commits March 5, 2023 23:01
@aaliddell
Merge pull request #247 from gonzojive/bzl-library
ce4d886 
Add bzl_library build targets.
@atavakoliyext
Reorder deps to pass Rulegen Diff check
59392b1
@aaliddell
Merge pull request #243 from yext/4.3.0-yext
5d63249 
Rename grpc_ecosystem_grpc_gateway to be consistent with the Go ecosystem
@github-actions github-actions bot added the lang-grpc-gateway grpc-gateway rules specific label Mar 7, 2023
@ash2k
Copy link
Contributor

ash2k commented Mar 29, 2023

Could you bump github.com/bufbuild/protoc-gen-validate please 🙏

danny-skydio and others added 2 commits April 5, 2023 17:01
@danny-skydio
Fix capitalization on Objective-C outputs
092451c 
The function in objectivec_helpers.cc also splits segments if they come
after a digit, which wasn't being handled correctly.

e.g. vector_3f -> Vector3F

This sadly makes this function a lot more complicated. I naively
transliterated the function, so I have no doubt that this could be
improved. I'd be slightly concerned about starlark performance if you
were using this for some absurd number of types.
@aaliddell
Merge pull request #253 from danny-skydio/master
b4bc48d 
Fix capitalization on Objective-C outputs containing digits
@aaliddell
Copy link
Member Author

aaliddell commented May 3, 2023 •
edited
Loading

Reviewing the ~250(!) changed files across those final 2 todos is proving difficult to find time for 😩. Since everything else is ready I'll cut this release as 4.4.0 and immediately open 4.5.0 for those remaining changes. I'll look at bumping protoc-gen-validate too, since that should take little time

@github-actions github-actions bot added the lang-go Go rules specific label May 3, 2023
@aaliddell aaliddell marked this pull request as ready for review May 3, 2023 12:19
@aaliddell aaliddell merged commit 298ac1a into master May 3, 2023
@Zetten
Copy link

Zetten commented May 5, 2023

Reviewing the ~250(!) changed files across those final 2 todos is proving difficult to find time for weary. Since everything else is ready I'll cut this release as 4.4.0 and immediately open 4.5.0 for those remaining changes. I'll look at bumping protoc-gen-validate too, since that should take little time

I've just rebased #250 on 4.4.0 to hopefully simplify the review (and see if buildkite passes this time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation lang-d D rules specific lang-go Go rules specific lang-grpc-gateway grpc-gateway rules specific lang-python Python rules specific
Projects
None yet
Milestone
No milestone
7 participants
@aaliddell @ClintLiddick @ash2k @Zetten @gonzojive @atavakoliyext @danny-skydio